Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataTableのタブのサイズ調整 #133

Merged
merged 5 commits into from
Jul 22, 2020
Merged

dataTableのタブのサイズ調整 #133

merged 5 commits into from
Jul 22, 2020

Conversation

noronaoki
Copy link
Contributor

@noronaoki noronaoki commented Jul 21, 2020

調整の意図としては、タブの横幅を固定ではなく成りにすることで、短いテキストと長いテキストが混在した時の違和感を取り払いたいというもの。(min-widthで最低限の横幅は持っている)

  • アクティブ、非アクティブ状態のpaddingを変更
  • タブコンテナ、タブアイテムの横幅の定義をautoに変更し、min-widthを設定
  • アクティブ状態のテキストの太さをノーマルに変更

@noronaoki
Copy link
Contributor Author

@yutaro1031 バトンタッチお願いします。

@youchann
Copy link
Contributor

@noronaoki

アクティブ状態のテキストの太さをノーマルに変更

↑はまだ未対応ですかね...?

@@ -154,7 +154,7 @@ export const WithTabs = () => (
filter: (data) => data.filter((item) => item.id >= 5),
},
{
label: "empty",
label: "empty data",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabの横幅がautoだということを強調するため

@noronaoki
Copy link
Contributor Author

@yutaro1031

アクティブ状態のテキストの太さをノーマルに変更

修正漏れでした〜
該当箇所を削ったんだけど、明示的にnormal入れておいたほうがいい?

@youchann
Copy link
Contributor

@noronaoki

該当箇所を削ったんだけど、明示的にnormal入れておいたほうがいい?

入れなくて問題ないです!!

@youchann youchann requested a review from maktak1995 July 22, 2020 01:44
Copy link
Contributor

@maktak1995 maktak1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@youchann youchann merged commit 997d600 into master Jul 22, 2020
@youchann youchann deleted the modify-tab branch July 22, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants