-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataTableのタブのサイズ調整 #133
dataTableのタブのサイズ調整 #133
Conversation
@yutaro1031 バトンタッチお願いします。 |
↑はまだ未対応ですかね...? |
@@ -154,7 +154,7 @@ export const WithTabs = () => ( | |||
filter: (data) => data.filter((item) => item.id >= 5), | |||
}, | |||
{ | |||
label: "empty", | |||
label: "empty data", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tabの横幅がautoだということを強調するため
@yutaro1031
修正漏れでした〜 |
入れなくて問題ないです!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです!
調整の意図としては、タブの横幅を固定ではなく成りにすることで、短いテキストと長いテキストが混在した時の違和感を取り払いたいというもの。(min-widthで最低限の横幅は持っている)