-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<Table />を角付きに戻す #134
<Table />を角付きに戻す #134
Conversation
前の角が丸くない https://deploy-preview-134--ingred-ui.netlify.app/?path=/story/table--overview |
@yutaro1031 それで大丈夫です! |
src/typings.d.ts
Outdated
@@ -17,3 +17,9 @@ declare module "*.svg" { | |||
export default svgUrl; | |||
export { svgComponent as ReactComponent }; | |||
} | |||
|
|||
type DeepPartial<T> = T extends Function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
拾い物のDeepPartial
入れてみた
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
拾ったurlとかあるといいかも
reduxだと
export type DeepPartial<T> = {
[K in keyof T]?: T[K] extends object ? DeepPartial<T[K]> : T[K]
}
こんな感じになってるね
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
たしかに...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reduxからのコピペの方が安心感あるので、reduxから取ってきますね!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです!
src/typings.d.ts
Outdated
@@ -17,3 +17,9 @@ declare module "*.svg" { | |||
export default svgUrl; | |||
export { svgComponent as ReactComponent }; | |||
} | |||
|
|||
type DeepPartial<T> = T extends Function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
拾ったurlとかあるといいかも
reduxだと
export type DeepPartial<T> = {
[K in keyof T]?: T[K] extends object ? DeepPartial<T[K]> : T[K]
}
こんな感じになってるね
ref: https://cartaholdings.slack.com/archives/CKYAWNNLX/p1595819586183500