dependabotでchangesetの自動生成をやめる #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8c50c16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👷 Deploy Preview for ingred-ui processing.
|
1 similar comment
👷 Deploy Preview for ingred-ui processing.
|
✅ Deploy Preview for ingred-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
penicillin0
commented
Jul 31, 2023
Comment on lines
20
to
+22
| - name: check changesets | ||
| run: make -f ci.mk check_changesets | ||
| if: github.actor != 'dependabot[bot]' |
There was a problem hiding this comment.
dependabotはchangesetをしていないくもいいので除外
takurinton
approved these changes
Jul 31, 2023
| @@ -95,6 +19,7 @@ jobs: | |||
| run: make -f ci.mk install | |||
| - name: check changesets | |||
| run: make -f ci.mk check_changesets | |||
| if: github.actor != 'dependabot[bot]' | |||
| @@ -4,84 +4,8 @@ on: | |||
| pull_request: | |||
|
|
|||
| jobs: | |||
| generate-changeset: | |||
There was a problem hiding this comment.
直でスクリプトを書いている場所を削れたの大変素敵でいい
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
ref: https://cartaholdings.slack.com/archives/C02Q8F3FQBC/p1690246043246829
depenadabotの場合は、自動でchangesetを実行することを試みていたが、以下の課題があった。
package.jsonが更新されない場合(yarn.lockのみの更新)の対処が難しい、無理やりやったとてもyarnに依存してしまうpatch以外を上げたいような大きなバージョンアップもpatchになるそのため、dependabotのPRはリリースノートには含めず、大きな変更があった場合のみ、depenadabot作成PRに手動でpushする方針とした。
やったこと