feat <Calendar /> component
#1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fcc2214 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ingred-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
snapshot は style やインターフェイス調整するタイミングで入れるのでここでは書いてない |
takurinton
commented
Aug 14, 2023
Comment on lines
+11
to
+12
| // CalendarRange が実装されたら移動する | ||
| export const Actions = memo(({ actions }: { actions?: Action[] }) => { |
There was a problem hiding this comment.
Actions はここに置いてるけど、範囲選択のコンポーネントを追加する段階でどこかに移行する。
イメージでは
- Calendar ディレクトリの下に CalendarRange も置く
- utils の下に CalendarUtils を作ってそこに置く
の2択で、多分前者
There was a problem hiding this comment.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #975