Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor datepicker #1372

Merged
merged 10 commits into from
Aug 17, 2023
Merged

Refactor datepicker #1372

merged 10 commits into from
Aug 17, 2023

Conversation

takurinton
Copy link
Contributor

@takurinton takurinton commented Aug 16, 2023

#975

やったこと

  • 未使用関数の削除
  • タイポの修正
  • import の修正
  • DateRangePicker/CalendarRange で使っている click state を定数に
  • CalendarRange で使っている day state を定数に
  • ディレクトリの整理(types から constants に)
  • react/jsx-handler-names を使ってる箇所を修正
  • 型の整理(範囲選択のところで直接型を指定していた箇所で DateRange 型を使う)
  • コメントの整理

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

🦋 Changeset detected

Latest commit: 1954113

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ingred-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for ingred-ui ready!

Name Link
🔨 Latest commit 1954113
🔍 Latest deploy log https://app.netlify.com/sites/ingred-ui/deploys/64dd6d05ec175300081dedc1
😎 Deploy Preview https://deploy-preview-1372--ingred-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ryokosuge ryokosuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

読みやすくなった!
LGTM 👍

@takurinton takurinton merged commit 827ca39 into master Aug 17, 2023
2 checks passed
@takurinton takurinton deleted the refactor-datepicker branch August 17, 2023 04:08
@FluctMember FluctMember mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants