Feat isOutsideRange prop
#1375
Merged
Feat isOutsideRange prop
#1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 574b04d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ingred-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
こんな感じで指定した範囲が disable になってる（スクロールはできる） |
takurinton
commented
Aug 18, 2023
| export const DayContainer = styled.button<{ selected: boolean }>` | ||
| const DayContainerBase = styled.button<{ selected?: boolean }>` |
There was a problem hiding this comment.
元々使っていた DayContainer をベースにして、DayContainer と DisableDayContainer の共通部分として定義
takurinton
commented
Aug 18, 2023
Comment on lines
+93
to
+94
| const isOutsideRange = (day: dayjs.Dayjs) => | ||
| day.isBefore(dayjs().subtract(1, "day")); |
There was a problem hiding this comment.
story では1日前から選択できないようにしている
takurinton
force-pushed
the
feat-is-outside-range-calendar
branch
from
996e914
to
574b04d
Compare
youchann
approved these changes
Aug 21, 2023
| dayjs(new Date(m.year(), m.month(), day)), | ||
| ); | ||
|
|
||
| return ( |
There was a problem hiding this comment.
nits
returnでネストしちゃうならインラインで書いちゃえ派だった。
There was a problem hiding this comment.
条件が若干複雑に見えるので分けてしまいました。
まあこういう派閥の領域を縛るなら lint かな。
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#975
isOutsideRangeprop の追加。react-dates の
isOutsideRangeprop と同じ挙動をする。以下のコンポーネントに追加。