-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat year and month select component #1385
Conversation
🦋 Changeset detectedLatest commit: bb96a59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ingred-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
アニメーションとかつけてないけど(今の構成だとつけられない?)けど、一旦挙動は満たしてる。 |
<InnerCalendar | ||
date={date} | ||
current={current} | ||
yearIsOpen={yearIsOpen} | ||
isOutsideRange={isOutsideRange} | ||
onYearIsOpen={setYearIsOpen} | ||
onDateChange={onDateChange} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
元々 <Calendar />
コンポーネントで読んでいたカレンダーは <InnerCalendar />
に分割。
分割しないと年月選択のコンポーネントの開閉で状態がリセットされないので observer の部分が呼ばれないため。
} | ||
}, [current]); | ||
|
||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
基本的に useScrollCalendar
と同じ構成になっている。
TODO
|
grid-auto-rows: ${({ theme }) => theme.spacing * 4}px; | ||
grid-gap: ${({ theme }) => theme.spacing * 1.2}px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
かなり目分量
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
まあひとまず動かすところまでという目的に対してなのでこれはこれで良さそう。
style 修正はまとめて最後にやる予定なのでこれで問題ない。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ソースコード上で気になるところなしでした!
バグの部分、いつ直すのかみたいなところは判断していだだけるとmm
@Yutan0423 |
@takurinton |
@Yutan0423
そうですね、実運用で弊害が出るようであれば検討します、ありがとうございます!!!! |
#975 (comment)
https://www.figma.com/file/fUeoFzCzL4rwRuW7CFW4m0/INGRED-UI?type=design&node-id=1263-1291&mode=design&t=0fnBZlfz2dyPtzgG-0
YearMonths
という名前にしてるInnerCalendar
InnerCalendarRange
styled.ts
はCalendar
ディレクトリの下のものを共通で使う