DataTableの<th />に文字列以外も含められるようにする #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youchann
commented
Jul 28, 2020
Comment on lines
+88
to
90
| // MEMO: nameを廃止して、headerCellのみにすることも可能 | ||
| // 他の破壊的変更に合わせて行うのが良さそう | ||
| name: string; |
There was a problem hiding this comment.
nameなくても良さそうと判断していますー
There was a problem hiding this comment.
名称をいれたいだけのときも ReactNodeで渡さなきゃいけないようになるとやりすぎな気がするので、stringで名称だけ渡すこともできるようになっているといいかなーと思います headerCell: React.ReactNode | string; みたいな感じで
There was a problem hiding this comment.
実はReact.ReactNode型にはstringが含まれているという噂が....
youchann
commented
Jul 28, 2020
| @@ -34,7 +34,7 @@ export const SortableHeaderCell: React.FunctionComponent<Props> = ({ | |||
| {...rest} | |||
| > | |||
| <Flex display="flex" alignItems="center"> | |||
| <Typography weight="bold" size="md" component="span"> | |||
| <Typography weight="bold" size="md" component="div"> | |||
There was a problem hiding this comment.
入れ子ルール違反を避けるべくdivに
youchann
commented
Jul 28, 2020
| width: 100%; | ||
| backdrop-filter: blur(2px); | ||
| background-color: ${({ theme }) => | ||
| hexToRgba(theme.palette.background.default, 0.9)}; | ||
| border-top: ${Size.Border.Small} solid ${({ theme }) => theme.palette.divider}; | ||
| border-bottom: ${Size.Border.Small} solid | ||
| ${({ theme }) => theme.palette.divider}; | ||
| ${({ theme }) => theme.palette.gray.light}; |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://cartaholdings.slack.com/archives/CFB92AX5J/p1595910530074100
close: #136
close: #137