-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat defaultClickAction prop #1420
Conversation
🦋 Changeset detectedLatest commit: 713057e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ingred-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
これだとカレンダーの開閉でステートがリセットされてしまうな...。 親コンポーネントで持ちたくない場合はそもそも defaultClickAction を渡さなければいいのでこれはこれで良さそう。 |
となると onActionClick が欲しくなる...。 |
@@ -79,6 +79,58 @@ export const WithActions: StoryObj<NewDateRangePickerProps> = { | |||
}, | |||
}; | |||
|
|||
export const WithActionsWithDefaultClickAction: StoryObj<NewDateRangePickerProps> = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これ用の story 追加しておいた。
Action prop でデフォルトで選択されてるアクションを表示したいユースケースがありそう