-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DateField style #1424
Fix DateField style #1424
Conversation
🦋 Changeset detectedLatest commit: ad1d482 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ingred-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a59c34c
to
a1c8c9e
Compare
export const DateInput = React.forwardRef<HTMLInputElement, InputProps>( | ||
function InputComponent({ error = false, ...rest }, ref) { | ||
return <Input {...rest} ref={ref} isError={error} />; | ||
}, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Input コンポーネントについてる overflow: scroll が悪さしていたので、それを削った DateField 用の Input コンポーネントを定義してみた。
暫定的な対応なので、後でもしかしたら違う方向に倒すかもしれないけど、ひとまずこれで既存の不具合は直る。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
手元のを見た感じだと、<Input />
側のoverflow: scroll
を消しても問題なさそうだったのだけど、どうかな
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
それでいいならそれでいいんですが、横幅が溢れたときにスクロールエリアになる挙動が正しいと思ったので <Input />
自体は変えないようにしました
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
と思ったけど勝手にスクロールになった、なるほど?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sousou
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
じゃあそうします
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そうした、自分の手元ではそもそもこのバグが再現しないので、再現する人に試してもらう
e0fbb49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit a1c8c9e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コードはしっかり見れてないけど手元で動作確認しましたー!
https://cartaholdings.slack.com/archives/CFB92AX5J/p1695279632260899