DataTableのrowSpan対応 #151
Merged
DataTableのrowSpan対応 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youchann
commented
Aug 5, 2020
Comment on lines
+122
to
+132
| columns={[ | ||
| { | ||
| name: "ID", | ||
| selector: (data) => data.id, | ||
| }, | ||
| { | ||
| name: "名前", | ||
| selector: (data) => data.name, | ||
| enableMergeCell: true, | ||
| sortable: true, | ||
| }, |
There was a problem hiding this comment.
columnに対してenableMergeCellを定義することでセル結合を可能にした。
enableMergeCellがtrueとなるcolumnが存在する時
- hover時の背景色変更が無効
- sort機能が無効
となる。
そのため、セル結合をしたい場合は配列の順序をライブラリ利用者側が考慮する必要がある。
There was a problem hiding this comment.
また、idをまたいだセル結合は行われない。
Comment on lines
+452
to
+460
| <td | ||
| colSpan={ | ||
| columns.length + | ||
| ((showCheckbox || showRadioButton) && | ||
| (!showTabs || isCheckableTab(currentTabIndex, tabs)) | ||
| ? 1 | ||
| : 0) | ||
| } | ||
| > |
There was a problem hiding this comment.
この辺は他のソースコードに干渉せず、あまり読まれないため、return構文の中に閉じ込めた。
|
@maktak1995 |
youchann
commented
Aug 5, 2020
Comment on lines
+60
to
+77
| function calculateRowSpan<T extends DataTableBaseData>( | ||
| column: Column<T>, | ||
| displayData: T[], | ||
| startIndex: number, | ||
| ): number { | ||
| if (!column.enableMergeCell) return 1; | ||
| const baseRow = displayData[startIndex]; | ||
| const baseCell = column.selector(baseRow); | ||
| let rowSpan = 1; | ||
| for (let idx = startIndex + 1; idx < displayData.length; idx++) { | ||
| const comparisonRow = displayData[idx]; | ||
| const comparisonCell = column.selector(comparisonRow); | ||
| if (comparisonRow.id !== baseRow.id || comparisonCell !== baseCell) { | ||
| break; | ||
| } | ||
| rowSpan++; | ||
| } | ||
| return rowSpan; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #148