💄 Add close_circle2 icon #1512
💄 Add close_circle2 icon #1512
Conversation
🦋 Changeset detectedLatest commit: 6ced605 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ingred-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/components/Icon/Icon.tsx
Outdated
| @@ -185,7 +186,8 @@ export type IconName = | |||
| | "bar_chart_search" | |||
| | "check_thin" | |||
| | "image_check" | |||
| | "group2"; | |||
| | "group2" | |||
| | "close_circle2"; | |||
There was a problem hiding this comment.
close_circle アイコンが既に存在するが、今回追加した Remix Icon の close_circle を使いたいので close_circle2 として定義した。noroさんとも会話済み。
|
@noronaoki https://deploy-preview-1512--ingred-ui.netlify.app/?path=/docs/components-data-display-icon--docs
|
|
@deatiger なので追加ではなく |
| fill="none" | ||
| const CloseCircleIcon: React.FunctionComponent<IconProps> = ({ | ||
| fill, | ||
| type = "fill", |
There was a problem hiding this comment.
置き換え前は type が1種類 (fillのみ ) だったので、デフォルト値としてfillを指定した。
|
@youchann @noronaoki |
Check List (If️ you added new component in this PR)
src/components/index.ts.storybook/documents/Information/Samples/Samples.stories.tsx