Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggleのレイアウト調整 #1529

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Toggleのレイアウト調整 #1529

merged 4 commits into from
Dec 5, 2023

Conversation

noronaoki
Copy link
Contributor

Toggleのレイアウト調整です。

  • デフォルトではラベルを使わないようにした
    • 日英表記などで切り替えた際、横幅が固定だとレイアウト崩れが起きるため
    • なお、ON/OFFでラベル長が違う時に大きさを揃えるために固定幅が必要なのでそちらを優先した
    • しかしながら日英翻訳などでラベル長が変わることを考慮するとラベルをセットするのは推奨されないので、デフォルトをラベル無しにした
  • 丸いボールの大きさと位置の微調整

Check List (If️ you added new component in this PR)

  • Export the component in src/components/index.ts
  • Add example to .storybook/documents/Information/Samples/Samples.stories.tsx
  • Localize added component

Copy link

changeset-bot bot commented Dec 5, 2023

🦋 Changeset detected

Latest commit: dd99406

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ingred-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for ingred-ui ready!

Name Link
🔨 Latest commit dd99406
🔍 Latest deploy log https://app.netlify.com/sites/ingred-ui/deploys/656ec1ea7fde7b00087e7686
😎 Deploy Preview https://deploy-preview-1529--ingred-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Yutan0423 Yutan0423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@noronaoki noronaoki merged commit 3373f15 into master Dec 5, 2023
3 checks passed
@noronaoki noronaoki deleted the modify-toggle branch December 5, 2023 06:42
@FluctMember FluctMember mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants