Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

border-radius: 4pxとなっているものを8pxに変更 #153

Merged
merged 7 commits into from
Aug 6, 2020
Merged

border-radius: 4pxとなっているものを8pxに変更 #153

merged 7 commits into from
Aug 6, 2020

Conversation

youchann
Copy link
Contributor

@youchann youchann commented Aug 6, 2020 •
edited

@youchann
Copy link
Contributor Author

youchann commented Aug 6, 2020 •
edited by noronaoki

UI変更のあるコンポーネント(snapshotが変更されているコンポーネント)

  • ActionButton
  • Button
  • ButtonGroup
  • CheckBox
  • ContextMenu
  • DataTable
  • DatePicker
  • DateRangePicker
  • DropdownButton
  • FloatingTip
  • Input
  • MenuList
  • Popover
  • Select
  • SnackBar
  • Switch
  • Table(多分「必須」のバッジ)
  • TextField

@youchann
Copy link
Contributor Author

youchann commented Aug 6, 2020

@noronaoki
おそらくborder-radiusを変更したくないコンポーネント(Checkboxとか)があると思うので、一旦ざっと目を通していただけると:bow:

@noronaoki
Copy link
Contributor

@yutaro1031 おーさっそくありがとうございます。確認する。

@noronaoki
Copy link
Contributor

  • checkbox
    • 角丸を4pxにする
  • datepicker
    • シャドウを消す
  • daterangepicker
    • シャドウを消す
  • pager
    • 角丸を8pxにする
  • select
    • 角丸を8pxにする
  • toast
    • 角丸を8pxにする
  • tooltip
    • 角丸を8pxにする

@youchann
Copy link
Contributor Author

youchann commented Aug 6, 2020

@noronaoki
#153 (comment)
↑対応しましたので、再度ご確認お願いしたいです:bow:

@noronaoki
Copy link
Contributor

@yutaro1031 LGTM!

maktak1995
maktak1995 approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@maktak1995 maktak1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです！

@youchann youchann merged commit d153779 into master Aug 6, 2020
@youchann youchann deleted the modify-border-radius branch August 6, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maktak1995 maktak1995 maktak1995 approved these changes

Assignees

@noronaoki noronaoki

@youchann youchann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@youchann @noronaoki @maktak1995