-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
palette.gray調整 #154
palette.gray調整 #154
Conversation
gray: { | ||
deepDark: colors.basic[700], | ||
dark: colors.basic[600], | ||
main: colors.basic[500], | ||
deepDark: colors.basic[600], | ||
dark: colors.basic[500], | ||
main: colors.basic[300], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 今のdeepDark消す
- その分色を繰り上げて、mainにbasic[300]を差し込む
background-color: ${({ active, theme }) => | ||
active ? colors.basic[100] : theme.palette.primary.highlight}; | ||
active ? theme.palette.gray.highlight : theme.palette.primary.highlight}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
おそらく背景色にはpalette.background
で指定したかったので直打ちをしていたのだと思う。
けれど、他の実装を見るとpalette.primary....
を背景色に指定しているので、そちらの方に合わせた。
コンポーネント自体に変化はないので、 |
今回の変更で |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです!
ref: https://github.com/voyagegroup/fluct_XDC/issues/45