Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DualListBox design #1540

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Fix DualListBox design #1540

merged 3 commits into from
Dec 22, 2023

Conversation

Yutan0423
Copy link
Contributor

@Yutan0423 Yutan0423 commented Dec 22, 2023

以下に対応

  • Dual listboxの左右の要素の一番下に下線を付ける(アコーディオンのみ)
  • Dual listboxのmax-widthを取っ払う

Check List (If️ you added new component in this PR)

  • Export the component in src/components/index.ts
  • Add example to .storybook/documents/Information/Samples/Samples.stories.tsx
  • Localize added component

Copy link

changeset-bot bot commented Dec 22, 2023

🦋 Changeset detected

Latest commit: 9b42a34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ingred-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for ingred-ui ready!

Name Link
🔨 Latest commit 9b42a34
🔍 Latest deploy log https://app.netlify.com/sites/ingred-ui/deploys/6585162fe603960008a668f0
😎 Deploy Preview https://deploy-preview-1540--ingred-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Yutan0423
Copy link
Contributor Author

max-witdthがなくなり、アコーディオンの下にボーダーがついた
https://deploy-preview-1540--ingred-ui.netlify.app/?path=/story/components-data-display-duallistbox--nested

既存のアコーディオンには影響なし

@Yutan0423 Yutan0423 self-assigned this Dec 22, 2023
@Yutan0423
Copy link
Contributor Author

@noronaoki ちょっと時間が経っており恐縮ですが、認識違いがないかご確認いただけますと幸いです!

@noronaoki
Copy link
Contributor

@Yutan0423 LGTM!!

@Yutan0423 Yutan0423 merged commit 7f06a50 into master Dec 22, 2023
3 checks passed
@Yutan0423 Yutan0423 deleted the fix-duallistbox branch December 22, 2023 07:23
@FluctMember FluctMember mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants