ItemEmptyのemptyStateIconを外部から設定できるようにする #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youchann
reviewed
Aug 6, 2020
Comment on lines
113
to
117
| emptyTitle?: string; | ||
| emptySubtitle?: string; | ||
| emptyImage?: string; | ||
| emptyImageWidth?: number; | ||
| emptyImageHeight?: number; |
There was a problem hiding this comment.
この辺は単一のオブジェクトで良いかもしれないですね。
// ↓<ItemEmpty />のprops
type ItemEmptyProps = {
title?: string;
subtitle?: string;
emptyImage?: string;
imageWidth?: number;
imageHeight?: number;
};ただ破壊的変更になるので
- とりあえず追加分のpropsだけオブジェクトで渡せるようにする
- 残りの
emptyTitle,emptySubTitleもオブジェクトに含める旨のIssueを書いて、同様の破壊的変更Issueと一緒に片付ける
みたいにするのが良さそうな気がしています！
youchann
approved these changes
Aug 7, 2020
Comment on lines
+105
to
+111
| // TODO: emptyTitle と emptySubtitle もここに移す | ||
| type ItemEmptyProps = { | ||
| emptyImage?: string; | ||
| imageWidth?: number; | ||
| imageHeight?: number; | ||
| }; | ||
|
|
There was a problem hiding this comment.
今は別ですが、最終的にはItemEmpty.tsxからpropsをimportするイメージです！
There was a problem hiding this comment.
了解です！またsubtitleなどをオブジェクトに追加したときに合わせてimportしますね！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #155