Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Toast />で長いメッセージ入れられるようにする #158

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

youchann
Copy link
Contributor

@youchann youchann commented Aug 6, 2020

close: #123
close: #130

@youchann youchann self-assigned this Aug 6, 2020
@youchann
Copy link
Contributor Author

youchann commented Aug 6, 2020

他の細かい奴もできそうか探す

@@ -34,6 +34,7 @@ export const Container = styled.div<ContainerProps>`
`;

export const IconContainer = styled.div<{ background: string }>`
flex-shrink: 0;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toast.stories.tsxとかで長い文字列当てて見ると検証できます

Copy link
Contributor

@maktak1995 maktak1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@youchann youchann merged commit 1d6fa69 into master Aug 6, 2020
@youchann youchann deleted the enable-toast-with-long-message branch August 6, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants