border-radiusをtheme経由で定義できるように #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youchann
changed the title
|
利用者側が全体で |
youchann
commented
Aug 6, 2020
| @@ -3,7 +3,7 @@ | |||
| exports[`ActionButton component testing ActionButton 1`] = ` | |||
| <DocumentFragment> | |||
| <button | |||
| class="sc-AxjAm hEzxlr" | |||
| class="sc-AxjAm bfURWn" | |||
There was a problem hiding this comment.
snapshotに変化のあるコンポーネントがちらほらありますが、実際にUIに差があるのかを見ていただけると:bow:
|
|
||
| export const Container = styled.button` | ||
| display: flex; | ||
| align-items: center; | ||
| padding: ${Space * 0.75}px ${Space}px; | ||
| border: 0; | ||
| cursor: pointer; | ||
| border-radius: ${Radius.MEDIUM}; | ||
| border-radius: ${({ theme }) => theme.radius}px; |
There was a problem hiding this comment.
theme.spacingと同じノリで扱える
youchann
commented
Aug 6, 2020
| @@ -50,15 +50,15 @@ const getContainerColorStyles = ( | |||
| background: theme.palette.white, | |||
| color: theme.palette.black, | |||
| boxShadow: "none", | |||
| border: `${Size.Border.Small} solid ${theme.palette.divider}`, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #117