Table周りの破壊的変更 #160
Merged
Table周りの破壊的変更 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youchann
commented
Aug 20, 2020
Comment on lines
-130
to
-131
| // MEMO: nameを廃止して、headerCellのみにすることも可能 | ||
| // 他の破壊的変更に合わせて行うのが良さそう |
There was a problem hiding this comment.
nameはなんだかんだkeypropsやsortキーとして用いるので、必要そう。
youchann
commented
Aug 20, 2020
| </RequiredBadge> | ||
| )} | ||
| </Flex> | ||
| <Typography component="div" weight="bold" size="md" lineHeight="normal"> |
There was a problem hiding this comment.
そういえばなんでlineHeightはdefaultで1.4なんだろう:thinking:
youchann
commented
Aug 20, 2020
Comment on lines
+26
to
+38
| <Table.HeaderCell width="177px"> | ||
| <Flex | ||
| display="flex" | ||
| justifyContent="space-between" | ||
| alignItems="center" | ||
| > | ||
| <Typography component="div" weight="bold" size="md"> | ||
| タイトル | ||
| </Typography> | ||
| <Badge color="danger" fontWeight="bold"> | ||
| 必須 | ||
| </Badge> | ||
| </Flex> |
There was a problem hiding this comment.
こんな感じで中身を自由に定義できるようにした。
|
@noronaoki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #125
ついでに https://github.com/voyagegroup/fluct_XDC/issues/53 も対応。
あとは、
<DataTable />のpropsの構造を変えた。