Table.Row: add verticalSpacing props #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* set padding-top & padding-bottom (same as `<DataTable />` )
youchann
approved these changes
Sep 4, 2020
src/components/Table/Table.tsx
Outdated
| children: React.ReactNode; | ||
| }; | ||
| export type Props = React.ComponentPropsWithRef<"table"> & | ||
| Partial<{ verticalSpacing: VerticalSpacing }>; |
There was a problem hiding this comment.
Suggested change
| Partial<{ verticalSpacing: VerticalSpacing }>; | |
| { verticalSpacing?: VerticalSpacting }; |
他のコンポーネントと合わせるとこの書き方が良さそうですね！
src/components/Table/Table.tsx
Outdated
| export type Props = { | ||
| children: React.ReactNode; | ||
| }; | ||
| export type Props = React.ComponentPropsWithRef<"table"> & |
There was a problem hiding this comment.
なるべく型もexportして、利用者がimportしやすい形にしています(このままでもimportできるけどfrom "ingred-ui/dist/Table"みたいな感じになる)
なので
export type TableProps = ...みたいに書いて、同階層のindex.tsにもexport { default, TableProps } from ..."と書いておくと良さそうです！
Comment on lines
63
to
64
| <Typography>verticalSpacing = small</Typography> | ||
| {table("small")} |
There was a problem hiding this comment.
ドキュメントのどこかにあったような気がするけど探せなかった。。。。
table("small")でコンポーネントをreturnさせるならJSXで書いた方が良いみたいな話をどこかで聞きました。(DATASTRAPにはこの書き方がないのでそうだったはず)
{["small", "medium", "large"].map(spacing => (....)}みたいに書いた方が良さそうです！
|
あ、あと、 |
|
ありがとう〜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<DataTable />)