<DataTable /> rowSpan利用時の全チェック対応 #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youchann
commented
Sep 7, 2020
Comment on lines
+186
to
+188
| const [selectedRows, setSelectedRows] = React.useState<Set<number>>( | ||
| new Set([]), | ||
| ); |
There was a problem hiding this comment.
Setで管理したので多分少し早くなる。
|
デバッグ方法はブランチ環境および本番環境で |
maktak1995
approved these changes
Sep 8, 2020
youchann
added a commit
that referenced
this pull request
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rowSpanを設定した<DataTable />で全チェックを行うと、結合したセル分のIDが重複する。ので対応した。