-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybookを6に上げる #198
Storybookを6に上げる #198
Conversation
yarn upgrade したらlinterこけるようになってしまったな |
This reverts commit 6e25e62.
Linter周りは別であげたいのでrevert |
.storybook/tsconfig.json
Outdated
@@ -13,6 +13,7 @@ | |||
"removeComments": false, | |||
"noEmit": false, | |||
"strict": true, | |||
"isolatedModules": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref https://qiita.com/jagaapple/items/ce0da04be28c35dc7d4f#1-3-3-re-exports-%E5%95%8F%E9%A1%8C
型のexportをわけたのもこれ起因
"isolatedModules": true
がデフォになるらしい
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
やったこと