Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybookを6に上げる #198

Merged
merged 11 commits into from
Nov 13, 2020
Merged

Storybookを6に上げる #198

merged 11 commits into from
Nov 13, 2020

Conversation

youchann
Copy link
Contributor

@youchann youchann commented Nov 13, 2020

やったこと

  • 型を別でexportする
  • Storybook周辺のライブラリを上げる
  • いらないライブラリ群の削除

@youchann youchann added the dependencies Pull requests that update a dependency file label Nov 13, 2020
@youchann youchann self-assigned this Nov 13, 2020
@youchann
Copy link
Contributor Author

yarn upgrade したらlinterこけるようになってしまったな

This reverts commit 6e25e62.
@youchann
Copy link
Contributor Author

Linter周りは別であげたいのでrevert

@@ -13,6 +13,7 @@
"removeComments": false,
"noEmit": false,
"strict": true,
"isolatedModules": true,
Copy link
Contributor Author

@youchann youchann Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref https://qiita.com/jagaapple/items/ce0da04be28c35dc7d4f#1-3-3-re-exports-%E5%95%8F%E9%A1%8C
型のexportをわけたのもこれ起因

"isolatedModules": trueがデフォになるらしい

@youchann youchann changed the title wip Storybookを上げる Storybookを上げる Nov 13, 2020
@youchann youchann changed the title Storybookを上げる Storybookを6に上げる Nov 13, 2020
Copy link
Contributor

@maktak1995 maktak1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@youchann youchann merged commit 4a14ebd into master Nov 13, 2020
@youchann youchann deleted the update-storybook-6 branch November 13, 2020 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants