Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependabot alertsの対応 #209

Merged
merged 1 commit into from
Nov 26, 2020
Merged

dependabot alertsの対応 #209

merged 1 commit into from
Nov 26, 2020

Conversation

ryokosuge
Copy link
Contributor

@ryokosuge ryokosuge commented Nov 26, 2020 •
edited

  • node-forge@^0.10.0
    • javascript / typescript 両方
    • webpack-dev-serverから依存が始まっていたので、upgradeして対応
  • serialize-javascript@^3.1.0
    • javascript / typescript 両方
    • webpackから依存が始まっていたので、upgradeして対応
  • bl
    • javascript
    • image-webpack-loaderから依存始まっていたので、upgradeして対応

upgradeしたあと、 yarn startで表示されることは確認済み

@ryokosuge ryokosuge self-assigned this Nov 26, 2020
@ryokosuge ryokosuge requested a review from a team as a code owner November 26, 2020 07:01
@ryokosuge ryokosuge requested review from youchann and removed request for a team November 26, 2020 07:01
youchann
youchann approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@youchann youchann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yarn upgradeでなんとかなったかんじですね

@ryokosuge
Copy link
Contributor Author

バージョニングがしっかりしていたおかげで難しいこともなく対応できてよかった

@ryokosuge ryokosuge merged commit 30bbc2a into master Nov 26, 2020
@ryokosuge ryokosuge deleted the fix-dependabot-alerts branch November 26, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youchann youchann youchann approved these changes

Assignees

@ryokosuge ryokosuge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryokosuge @youchann