Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileUploaderのスタイルを修正 #214

Merged
merged 3 commits into from
Dec 3, 2020
Merged

FileUploaderのスタイルを修正 #214

merged 3 commits into from
Dec 3, 2020

Conversation

maktak1995
Copy link
Contributor

@maktak1995 maktak1995 requested a review from a team as a code owner December 1, 2020 07:26
@maktak1995 maktak1995 requested review from penicillin0 and removed request for a team December 1, 2020 07:26
@maktak1995 maktak1995 requested review from youchann and removed request for penicillin0 December 1, 2020 08:46
Copy link
Contributor

@youchann youchann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@@ -9,6 +9,7 @@ export type FileUploaderProps = {
description?: string;
title?: string;
accept?: string;
width?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: import { Property } from "csstype";してProperty.widthみたいなのでも良いかも

@maktak1995 maktak1995 merged commit 6c46a7f into master Dec 3, 2020
@maktak1995 maktak1995 deleted the fixFileUploader branch December 3, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants