Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak <Select /> props #219

Merged
merged 2 commits into from
Dec 14, 2020
Merged

tweak <Select /> props #219

merged 2 commits into from
Dec 14, 2020

Conversation

youchann
Copy link
Contributor

@youchann youchann commented Dec 14, 2020

componentsを自由にオーバーライドできるように
https://cartaholdings.slack.com/archives/CKYAWNNLX/p1607923267257100

@youchann youchann self-assigned this Dec 14, 2020
@youchann youchann requested a review from a team as a code owner December 14, 2020 05:29
@youchann youchann removed the request for review from maktak1995 December 14, 2020 05:29
@youchann
Copy link
Contributor Author

a,漏れあったので少々おまちを...

Comment on lines 195 to +205
{...rest}
components={{
DropdownIndicator: (props) => (
<DropdownIndicator {...props} error={error} />
),
ClearIndicator,
IndicatorSeparator: null,
MultiValueRemove,
MenuList: Styled.ReactSelectMenuList,
...rest.components,
}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...restの下においたので丸っとオーバーライドはされない

Copy link
Contributor

@maktak1995 maktak1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@youchann
Copy link
Contributor Author

mm

@youchann youchann merged commit 705fc26 into master Dec 14, 2020
@youchann youchann deleted the tweak-select-props branch December 14, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants