Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox: 内部の<input />のrefを扱えるように #222

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

youchann
Copy link
Contributor

No description provided.

@youchann youchann added the enhancement New feature or request label Dec 17, 2020
@youchann youchann self-assigned this Dec 17, 2020
@youchann youchann requested a review from a team as a code owner December 17, 2020 03:47
@youchann youchann requested review from penicillin0 and removed request for a team December 17, 2020 03:47
};

const Checkbox: React.FunctionComponent<CheckBoxProps> = ({
children,
indeterminate = false,
checked = false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

デフォルトがfalseだとreact-hook-formで扱えないのでやめた

@youchann youchann requested review from maktak1995 and removed request for penicillin0 December 17, 2020 03:48
Copy link
Contributor

@maktak1995 maktak1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@youchann youchann merged commit 0a66321 into master Dec 17, 2020
@youchann youchann deleted the refactor-useful-for-react-hook-form branch December 17, 2020 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants