Badgeコンポーネントの追加 #24
Merged
Badgeコンポーネントの追加 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
あー、命名は検討余地あるかも。 Badgeって、こっちのイメージもある。 |
|
TODO: padding変える。 |
Material-UI文脈のBadgeは別コンポーネントで提供すると良いかも。 |
|
↑あとで作ろうねという話に |
を自由に決められるようにする |
kinokoruumu
reviewed
May 14, 2020
src/components/Badge/styled.ts
Outdated
|
|
||
| export const Container = styled.span<Props>` | ||
| display: inline-block; | ||
| padding: 0.25em 0.7em; |
There was a problem hiding this comment.
当てました!(noroさんとdesign確認済み)
youchann
commented
May 15, 2020
| export const Container = styled.span<Props>` | ||
| display: inline-block; | ||
| padding: ${({ theme }) => `${theme.spacing / 2}px ${theme.spacing}px`}; | ||
| border-radius: ${({ type }) => type === "pill" ? "10rem" : "4px"}; |
There was a problem hiding this comment.
pill型の場合は極端に大きな値を埋めることで、要素の大きさに依存することなく形を表示するようにした。with noroさん
kinokoruumu
reviewed
May 18, 2020
| color, | ||
| type = "normal", | ||
| component = "span", | ||
| fontSize = "0.65em", |
There was a problem hiding this comment.
htmlに当たってるfont-size依存になるのでpx指定がいいかと！
There was a problem hiding this comment.
https://getbootstrap.com/docs/4.4/components/badge/
- bootstrapのように親要素からよしなにサイズを決めたい
- とはいえど細かい調整をしたいときもあるよね
みたいな流れでfontSizepropsが誕生したのですが、em指定に大きなデメリットとかってあったりしますかね...?
There was a problem hiding this comment.
なるほど！！そういう意図だったのか！
storybook見たらいい感じになってたので大丈夫そう！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.