Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

カードに枠線を付ける #240

Merged
merged 5 commits into from
Feb 1, 2021
Merged

カードに枠線を付ける #240

merged 5 commits into from
Feb 1, 2021

Conversation

maktak1995
Copy link
Contributor

ref: https://github.com/voyagegroup/fluct_XDC/issues/110
ref: https://github.com/voyagegroup/fluct_XDC/issues/111
ref: https://github.com/voyagegroup/fluct_XDC/issues/112

Border付きCardのようす
スクリーンショット 2021-02-01 15 58 49

cursor: not-allowed を追加したコンポーネント

  • Button
  • ButtonGroup (Buttonへの追加の影響)
  • Checkbox
  • DropdownButton (Buttonへの追加の影響)
  • Input
  • Select
  • ToggleButton
  • RadioButton

@maktak1995 maktak1995 requested a review from a team as a code owner February 1, 2021 07:03
@maktak1995 maktak1995 self-assigned this Feb 1, 2021
Copy link
Contributor

@youchann youchann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

色の変更によって他のコンポーネントにも影響出ていますが、そのあたりの共有をnoroさんとした方が良さそうです。

transition: all 0.3s;

&:hover {
&:hover:not([disabled]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:disabledで表現するものかと思ってましたが、[]でいけるんですね

@noronaoki
Copy link
Contributor

@maktak1995 デザインチェックOKです!

@maktak1995 maktak1995 merged commit 237db9c into master Feb 1, 2021
@maktak1995 maktak1995 deleted the addBorderToCard branch February 1, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants