日本語の部分を英語にする vol1 #251
Merged
日本語の部分を英語にする vol1 #251
+250
−270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youchann
commented
Feb 22, 2021
| }) => ( | ||
| // MEMO: Add className props to apply style | ||
| <a href={href} className={className} {...rest}> | ||
| <a href={href} className={className}> |
There was a problem hiding this comment.
{...rest}を加えると意図しないpropsも入り、警告が出るため変更。
youchann
commented
Feb 22, 2021
| return React.cloneElement(child, childNeighborDisabledProps); | ||
| } | ||
| return React.cloneElement(child, childProps); | ||
| const Button = React.cloneElement(child, { |
youchann
commented
Feb 22, 2021
|
|
||
| // MEMO: おそらくstyled-component@5.x.xで型エラーが起こっているので、明示的に宣言している |
There was a problem hiding this comment.
直してみたら型エラーが出なかったので対応。
youchann
commented
Feb 22, 2021
| const margin = getMargin({ | ||
| theme, | ||
| m: 1, | ||
| describe("margin", () => { |
There was a problem hiding this comment.
marginについて、paddingについてそれぞれグルーピングした(出力がみやすくなる
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #152
ひとまずコンポーネントの修正が不要となる部分は当PRでなおす。
が、propsの初期値は英語に切り替わるものもある。
propsの初期値が変わるコンポーネント
<FileUploader /><ConfirmModal />別PRで対応するコンポーネント
<DataTable /><DatePicker /><DateRangePicker /><NavigationRail />(Footer)<TextField />