Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

日本語の部分を英語にする vol2 #252

Merged
merged 12 commits into from
Apr 30, 2021
Merged

日本語の部分を英語にする vol2 #252

merged 12 commits into from
Apr 30, 2021

Conversation

youchann
Copy link
Contributor

@youchann youchann commented Feb 22, 2021 •
edited

close: #152

対応するコンポーネント

  • <DataTable />
  • <DatePicker />
  • <DateRangePicker />
  • <NavigationRail />(Footer)
  • <TextField />

@youchann youchann self-assigned this Feb 22, 2021
youchann
youchann commented Feb 22, 2021
View reviewed changes
src/components/DataTable/internal/CountChanger/CountChanger.tsx
Comment on lines +72 to +76
{labelDisplayedRows({
from: firstItemIndex,
to: lastItemIndex,
total,
})}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こんな感じで文字列の定義を利用者側で定義できるようにした。

いずれは
https://material-ui.com/guides/localization/#locale-text
みたいに全体で一気に定義できたりするようにしたい。

@youchann youchann changed the title 日本語の部分を英語にする vol2 wip 日本語の部分を英語にする vol2 Feb 22, 2021
@youchann youchann marked this pull request as ready for review February 22, 2021 08:12
@youchann youchann requested a review from a team as a code owner February 22, 2021 08:12
@youchann youchann removed the request for review from a team February 22, 2021 08:12
@youchann youchann marked this pull request as draft February 22, 2021 08:13
@youchann
Copy link
Contributor Author

#152 (comment)
結構時間かけても良さそうなやつだった

@youchann
Copy link
Contributor Author

【メモ】

  • 一旦このPRでは日本語→英語にしておく
  • マージ&リリースはしない(DSTなどで余計な作業をさせないため)
  • このPRに向けて多言語対応化のPRを作る

こんな感じの方向で考えている。

@youchann
Copy link
Contributor Author

#252 (comment)

こちらはとりあえず英語化したもので、多言語化に対応したのちにリリース予定です(DSTなどのプロダクトでの作業を減らすため)
なのでお手すきのタイミングでのんびりと見ていただけるとmm

maktak1995
maktak1995 approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@maktak1995 maktak1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@youchann
Copy link
Contributor Author

@maktak1995
提案なのですが、日本語→英語となったこのPRをリリースしても良いでしょうか...?
DSTの方での対応が手間になってしまうのですが、日本語がなくなる(はず)なので、よりOSSっぽくなります。

@maktak1995
Copy link
Contributor

大丈夫です〜
現状の実装だと各コンポーネントごとに単語を引数で渡さないといけなくなってしまうので、どこかのタイミングで集中して管理できる仕組みが欲しくなりそうですね

@youchann youchann mentioned this pull request Apr 26, 2021
Closed
@youchann youchann changed the title wip 日本語の部分を英語にする vol2 日本語の部分を英語にする vol2 Apr 26, 2021
@youchann youchann marked this pull request as ready for review April 26, 2021 04:26
@youchann youchann mentioned this pull request Apr 26, 2021
Closed
@netlify
Copy link

netlify bot commented Apr 26, 2021 •
edited

Deploy preview for ingred-ui ready!

Built with commit 48369f7

https://deploy-preview-252--ingred-ui.netlify.app

@youchann youchann merged commit ec3082a into master Apr 30, 2021
@youchann youchann deleted the translate-ja-to-en-vol2 branch April 30, 2021 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maktak1995 maktak1995 maktak1995 approved these changes

Assignees

@youchann youchann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

コメントアウト等を英語に切り替える
2 participants
@youchann @maktak1995