Buttonからmin-width除去 & menuContentsにdisabledを追加 #254

maktak1995 · 2021-03-10T03:02:02Z

Buttonからmin-width除去

menuContentsにdisabledを追加

maktak1995 · 2021-03-10T05:13:44Z

挙動・デザインは野呂さんにLGTMいただき済み
https://cartaholdings.slack.com/archives/CKYAWNNLX/p1615350654392900

penicillin0

LGTMです!

Storybook向けに以下のみ気になったので、確認お願いしますmm

ここのコメントにdisableが必要そうです！(ContentPropをprposに持つ他のコンポーネントについても同様)

ingred-ui/src/components/ContextMenu/ContextMenu.tsx

Lines 9 to 15 in 4b477a1

    
             /** 
        
              * `type ContentProp = React.ComponentPropsWithRef<"div"> & { 
        
              *   text: string; 
        
              *   onClick: () => void; 
        
              *   divideTop?: boolean; 
        
              * }` 
        
              */

ここを変更するとDocsのContentPropの説明も反映されると思います↓

maktak1995 added 3 commits March 10, 2021 11:23

Buttonからmin-widthを除去

c83eaf8

menuContentsにdisabledOptionを追加

b13446d

update snapshot

68991d2

maktak1995 requested a review from a team as a code owner March 10, 2021 03:02

fix LintError

4b477a1

maktak1995 self-assigned this Mar 10, 2021

maktak1995 requested review from ryokosuge and penicillin0 and removed request for a team and ryokosuge March 10, 2021 04:52

penicillin0 approved these changes Mar 10, 2021

View reviewed changes

コメントを追記

ced70a6

maktak1995 merged commit 413be50 into master Mar 10, 2021

maktak1995 deleted the addButtonSize branch March 10, 2021 05:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Buttonからmin-width除去 & menuContentsにdisabledを追加 #254

Buttonからmin-width除去 & menuContentsにdisabledを追加 #254

maktak1995 commented Mar 10, 2021

maktak1995 commented Mar 10, 2021

penicillin0 left a comment

	/**
	* `type ContentProp = React.ComponentPropsWithRef<"div"> & {
	* text: string;
	* onClick: () => void;
	* divideTop?: boolean;
	* }`
	*/

Buttonからmin-width除去 & menuContentsにdisabledを追加 #254

Buttonからmin-width除去 & menuContentsにdisabledを追加 #254

Conversation

maktak1995 commented Mar 10, 2021

maktak1995 commented Mar 10, 2021

penicillin0 left a comment

Choose a reason for hiding this comment