Revert "Buttonからmin-widthを除去" #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c83eaf8.
ryokosuge
reviewed
Mar 23, 2021
src/components/Button/Button.tsx
Outdated
Comment on lines
121
to
134
| const buttonSize: Record<ButtonSize, { minWidth: string; height: string }> = { | ||
| small: { | ||
| minWidth: "64px", | ||
| height: "32px", | ||
| }, | ||
| medium: { | ||
| minWidth: "130px", | ||
| height: "42px", | ||
| }, | ||
| large: { | ||
| minWidth: "178px", | ||
| height: "48px", | ||
| }, | ||
| }; |
There was a problem hiding this comment.
height は復活させちゃって大丈夫？
確かゴリにゃのPRで消したんじゃなかったっけ？？
There was a problem hiding this comment.
revertする際にどこまで消せばいいのか分からず、一旦残しておきました！
確かに僕のPRでheightは削除しているので、消しちゃっても大丈夫そうです！
確認して修正します！
|
@ryokosuge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c83eaf8.
やったこと
min-widthを削除したことによって、ボタンテキストが日本語の際にボタンの横幅がおかしくなるので、min-widthを削除したコミットをrevertした。
問題のスクショ
Before
After