Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybookにINGRED-UIのfaviconを設定 #307

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

deatiger
Copy link
Collaborator

設定方法は以下のIssueを参照した
https://github.com/storybookjs/storybook/issues/6155

やったこと

  1. .storybook/manager.jsを作成
  2. .storybook/manager.jsでfaviconファイルをimport
  3. .storybook/manager-head.htmlを作成してfaviconの記述を書く(hrefのパスはstorybookのコマンドで-s assetsのように指定している静的ファイルディレクトリからの絶対パス)

@deatiger deatiger requested a review from a team as a code owner April 15, 2021 09:50
@deatiger deatiger requested review from ryokosuge and removed request for a team April 15, 2021 09:50
@deatiger deatiger added the enhancement New feature or request label Apr 15, 2021
Copy link
Contributor

@ryokosuge ryokosuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deatiger deatiger merged commit 34b26df into update-storybook-theme Apr 15, 2021
@deatiger deatiger deleted the try-change-favicon branch April 15, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants