Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

成果物の動作検証ができる環境を作る #331

Merged
merged 4 commits into from
Apr 30, 2021
Merged

成果物の動作検証ができる環境を作る #331

merged 4 commits into from
Apr 30, 2021

Conversation

youchann
Copy link
Contributor

close: #329

@youchann youchann added the enhancement New feature or request label Apr 30, 2021
@youchann youchann requested a review from a team as a code owner April 30, 2021 09:19
@youchann youchann self-assigned this Apr 30, 2021
@youchann youchann requested review from ryokosuge and removed request for a team April 30, 2021 09:19
@netlify
Copy link

netlify bot commented Apr 30, 2021 •
edited

Deploy preview for ingred-ui ready!

Built with commit 08f64b0

https://deploy-preview-331--ingred-ui.netlify.app

@youchann
Copy link
Contributor Author

基本的には

  • examples/create-react-appからtestEnv/にコピー
  • testEnv/package.jsonを編集(ローカルのdist/から取ってくるように)

を行った。

ryokosuge
ryokosuge approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@ryokosuge ryokosuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youchann
Copy link
Contributor Author

examples/create-react-appは「とりあえずこれで試してみてよ！」つまりユーザー向け。
testEnvは「成果物がちゃんと動くのか試してみよう！」つまり開発者向け。
みたいな棲み分け。

本当はCI上でいい感じに自動化したかったのだけれども、

  • 成果物がちゃんと動くのかを検証する

という目的に対してはコスト感が見合っていない気がした。
そもそもこの↑検証をしたいときは依存を上げたとき(のみ)なので。

@youchann youchann merged commit 25a76f3 into master Apr 30, 2021
@youchann youchann deleted the add-verification-environment branch April 30, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryokosuge ryokosuge ryokosuge approved these changes

Assignees

@youchann youchann

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

成果物の動作担保を行える仕組みがほしい
2 participants
@youchann @ryokosuge