Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update renovate.json #363

Merged
merged 2 commits into from
May 28, 2021
Merged

Update renovate.json #363

merged 2 commits into from
May 28, 2021

Conversation

YOwatari
Copy link
Member

schedule がおかしい

やりたいことはこれでいいだろうか
https://docs.renovatebot.com/presets-schedule/#schedulenonofficehours

Check List (If️ you added new component in this PR)

  • Export the component in src/components/index.ts
  • Add example to .storybook/documents/Information/Samples/Samples.stories.tsx

schedule がおかしい

やりたいことはこれでいいだろうか
https://docs.renovatebot.com/presets-schedule/#schedulenonofficehours
@YOwatari YOwatari requested a review from a team as a code owner May 28, 2021 08:10
@YOwatari YOwatari requested review from penicillin0 and removed request for a team May 28, 2021 08:10
@YOwatari
Copy link
Member Author

条件逆かな?オフィス時間中だけ動くようにしたい?

@penicillin0
Copy link
Contributor

@YOwatari
オフィス時間中ですね

renovate.json Outdated
"schedule": [
"after 9:30am every weekday",
"before 6:30pm every weekday",
"every weekend"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"every weekend"
これはいらないかも?

@youchann
↑どうでしょう??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

オフィス時間中ならevery weekdayでしょうか

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

正味自分が書いたわけではなく、とりあえず業務時間内に動けば良いかなとか思っておりますw

なので、動けば何でもよいですよ...w

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほどですmm

@YOwatari
Copy link
Member Author

そもそも after/before からそうだった
削った

@netlify
Copy link

netlify bot commented May 28, 2021

✔️ Deploy Preview for ingred-ui ready!

🔨 Explore the source changes: 09c2c7e

🔍 Inspect the deploy log: https://app.netlify.com/sites/ingred-ui/deploys/60b0a790e0b8c30007ca0395

😎 Browse the preview: https://deploy-preview-363--ingred-ui.netlify.app

@YOwatari
Copy link
Member Author

んじゃ、これでマージして様子みてみよう

Copy link
Contributor

@penicillin0 penicillin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ありがとうございます!

@YOwatari YOwatari merged commit 01be184 into master May 28, 2021
@YOwatari YOwatari deleted the YOwatari-patch-1 branch May 28, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants