Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Noteを自動生成する #366

Merged
merged 4 commits into from
May 31, 2021
Merged

Conversation

ryokosuge
Copy link
Contributor

やったこと

  • draftで生成するReleaseのbodyを自動生成する
  • Release PRのdescriptionをわかりやすくした

@ryokosuge ryokosuge added the enhancement New feature or request label May 31, 2021
@ryokosuge ryokosuge self-assigned this May 31, 2021
@ryokosuge ryokosuge requested a review from a team as a code owner May 31, 2021 02:55
@ryokosuge ryokosuge requested review from penicillin0 and removed request for a team May 31, 2021 02:55
@netlify
Copy link

netlify bot commented May 31, 2021

✔️ Deploy Preview for ingred-ui ready!

🔨 Explore the source changes: 7af3fcc

🔍 Inspect the deploy log: https://app.netlify.com/sites/ingred-ui/deploys/60b45031b60b240007771440

😎 Browse the preview: https://deploy-preview-366--ingred-ui.netlify.app

@ryokosuge ryokosuge requested a review from youchann May 31, 2021 02:55
Comment on lines +15 to +16
- name: Unshallow
run: git fetch --prune --unshallow --tags
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

タグ情報を取得する

Comment on lines +32 to +40
release_note:
github_changelog_generator \
--user voyagegroup \
--project ingred-ui \
--exclude-labels release \
--future-release v${RELEASE_VERSION} \
--since-tag $(shell git describe --abbrev=0 --tags) \
--output ${OUTPUT_FILE} \
--token ${GITHUB_TOKEN}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--since-tagで現状の最新のタグを指定することでrelease前の差分でchangelogを生成するようにした

こんな感じになる
https://github.com/voyagegroup/ingred-ui/releases/tag/untagged-43c4d552d3ef288ca7a6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このdraftはrelease前に閉じる

@ryokosuge ryokosuge removed the request for review from penicillin0 May 31, 2021 02:59
Copy link
Contributor

@youchann youchann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

リリースフローのドキュメントの方も自動で差分検知できる旨を書き加えたりしていただけると:bow:

@ryokosuge ryokosuge merged commit be57e3d into master May 31, 2021
@ryokosuge ryokosuge deleted the feature/release-draft-pr-body branch May 31, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants