Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update non-major #386

Merged
merged 28 commits into from
Jun 21, 2021
Merged

Update non-major #386

merged 28 commits into from
Jun 21, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 17, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@testing-library/jest-dom 5.12.0 -> 5.14.1 age adoption passing confidence
@testing-library/react 11.2.6 -> 11.2.7 age adoption passing confidence
@types/node 12.19.9 -> 12.20.15 age adoption passing confidence
@types/react 17.0.5 -> 17.0.11 age adoption passing confidence
@types/react 17.0.4 -> 17.0.11 age adoption passing confidence
@types/react-dom 17.0.5 -> 17.0.7 age adoption passing confidence
@types/react-dom 17.0.3 -> 17.0.7 age adoption passing confidence
@types/styled-components 5.1.5 -> 5.1.10 age adoption passing confidence
@types/styled-components 5.1.9 -> 5.1.10 age adoption passing confidence
@typescript-eslint/eslint-plugin 4.22.0 -> 4.27.0 age adoption passing confidence
@typescript-eslint/parser 4.22.0 -> 4.27.0 age adoption passing confidence
eslint (source) 7.25.0 -> 7.28.0 age adoption passing confidence
eslint-plugin-import 2.22.1 -> 2.23.4 age adoption passing confidence
eslint-plugin-mdx 1.12.0 -> 1.13.0 age adoption passing confidence
eslint-plugin-react 7.23.2 -> 7.24.0 age adoption passing confidence
prettier (source) 2.2.1 -> 2.3.1 age adoption passing confidence
react-hook-form (source) 6.13.1 -> 6.15.8 age adoption passing confidence
rollup (source) 2.45.2 -> 2.52.1 age adoption passing confidence
styled-components (source) 5.2.1 -> 5.3.0 age adoption passing confidence
styled-components (source) 5.2.3 -> 5.3.0 age adoption passing confidence
ts-jest (source) 26.5.5 -> 26.5.6 age adoption passing confidence
typescript (source) 4.1.3 -> 4.3.4 age adoption passing confidence
typescript (source) 4.2.4 -> 4.3.4 age adoption passing confidence

Release Notes

testing-library/jest-dom

v5.14.1

Compare Source

Bug Fixes

v5.14.0

Compare Source

Features
  • toHaveAccessibleName and toHaveAccessibleDescription (#​377) (87ffd2a)

v5.13.0

Compare Source

Features
testing-library/react-testing-library

v11.2.7

Compare Source

Bug Fixes
typescript-eslint/typescript-eslint

v4.27.0

Compare Source

Bug Fixes
  • eslint-plugin: allow explicit any for no-unsafe-return (#​3498) (b15a2b2)
  • typescript-estree: allow providing more one than one existing program in config (#​3508) (4f1806e)
  • typescript-estree: support override modifier for parameter property (#​3485) (33b9f69)
Features
  • ast-spec: specify LogicalExpression's operator type (#​3497) (9e343fd)
  • ast-spec: specify PunctuatorToken's value type (#​3496) (fdb1d81)
  • eslint-plugin: [prefer-literal-enum-member] add allowBitwiseExpressions option (#​3515) (288092a)
  • typescript-estree: add opt-in inference for single runs and create programs for projects up front (#​3512) (06c2d9b)
  • allow user to provide TS program instance in parser options (#​3484) (e855b18)

4.26.1 (2021-06-07)

Bug Fixes

v4.26.1

Compare Source

Bug Fixes

v4.26.0

Compare Source

Bug Fixes
Features
  • eslint-plugin: [member-ordering] add callback as an ordering type of node (#​3354) (d134b1f)
  • eslint-plugin: [space-infix-ops] Add support for Union and intersection of type declarations (#​3360) (3d29323)
  • scope-manager: reduce generated lib file size (#​3468) (258116b)

v4.25.0

Compare Source

Bug Fixes
  • corrected no-unsupported-browser-code in roadmap as unimplemented (#​3407) (2319b0e)
  • experimental-utils: fix isAwaitKeyword predicate in ast-utils (#​3290) (c15da67)
Features

v4.24.0

Compare Source

Bug Fixes
  • eslint-plugin: [no-shadow] fix static class method generics shadowing class generics (#​3393) (b1e1c8a), closes #​2592
  • eslint-plugin: [no-unsafe-*] special case handling for the empty map constructor with no generics (#​3394) (cae4f4a), closes #​2109
Features
  • eslint-plugin: [dot-notation] optionally allow square bracket notation where an index signature exists in conjunction with noPropertyAccessFromIndexSignature (#​3361) (37ec2c2)

v4.23.0

Compare Source

Bug Fixes
  • scope-manager: fix visiting TSAsExpression in assignment (#​3355) (87521a0)
Features
  • experimental-utils: Include getCwd() in RuleContext type (#​3308) (2b75c11)
  • refactor to split AST specification out as its own module (#​2911) (25ea953)

4.22.1 (2021-05-04)

Note: Version bump only for package @​typescript-eslint/typescript-eslint

v4.22.1

Compare Source

Note: Version bump only for package @​typescript-eslint/typescript-eslint

eslint/eslint

v7.28.0

Compare Source

v7.27.0

Compare Source

  • 2c0868c Chore: merge all html formatter files into html.js (#​14612) (Milos Djermanovic)
  • 9e9b5e0 Update: no-unused-vars false negative with comma operator (fixes #​14325) (#​14354) (Nitin Kumar)
  • afe9569 Chore: use includes instead of indexOf (#​14607) (Mikhail Bodrov)
  • c0f418e Chore: Remove lodash (#​14287) (Stephen Wade)
  • 52655dd Update: no-restricted-imports custom message for patterns (fixes #​11843) (#​14580) (Alex Holden)
  • 967b1c4 Chore: Fix typo in large.js (#​14589) (Ikko Ashimine)
  • 2466a05 Sponsors: Sync README with website (ESLint Jenkins)
  • fe29f18 Sponsors: Sync README with website (ESLint Jenkins)
  • 086c1d6 Chore: add more test cases for no-sequences (#​14579) (Nitin Kumar)
  • 6a2ced8 Docs: Update README team and sponsors (ESLint Jenkins)

v7.26.0

Compare Source

  • aaf65e6 Upgrade: eslintrc for ModuleResolver fix (#​14577) (Brandon Mills)
  • ae6dbd1 Fix: track variables, not names in require-atomic-updates (fixes #​14208) (#​14282) (Patrick Ahmetovic)
  • 6a86e50 Chore: remove loose-parser tests (fixes #​14315) (#​14569) (Milos Djermanovic)
  • ee3a3ea Fix: create .eslintrc.cjs for module type (#​14304) (Nitin Kumar)
  • 6791dec Docs: fix example for require-atomic-updates (#​14562) (Milos Djermanovic)
  • 388eb7e Sponsors: Sync README with website (ESLint Jenkins)
  • f071d1e Update: Add automated suggestion to radix rule for parsing decimals (#​14291) (Bryan Mishkin)
  • 0b6a3f3 New: Include XO style guide in eslint --init (#​14193) (Federico Brigante)
benmosher/eslint-plugin-import

v2.23.4

Compare Source

Fixed
  • [no-import-module-exports]: Don't crash if packages have no entrypoint ([#​2099], thanks [@​eps1lon])
  • [no-extraneous-dependencies]: fix package name algorithm ([#​2097], thanks [@​paztis])

v2.23.3

Compare Source

Fixed
Changed
  • [Docs] Add no-relative-packages to list of to the list of rules ([#​2075], thanks [@​arvigeus])

v2.23.2

Compare Source

Changed
  • [meta] add safe-publish-latest; use prepublishOnly script for npm 7+

v2.23.1

Compare Source

Fixed

v2.23.0

Compare Source

Added
Fixed
Changed
mdx-js/eslint-mdx

v1.13.0

Compare Source

Bug Fixes
Features
  • fallback to async API on processSync error via synckit (#​307) (94a08af)
  • performance improvement via cache (a893aa7)
  • use official eslint-plugin-markdown package (#​304) (e6828be)
yannickcr/eslint-plugin-react

v7.24.0

Compare Source

Added
Fixed
Changed
prettier/prettier

v2.3.1

Compare Source

diff

Support TypeScript 4.3 (#​10945 by @​sosukesuzuki)
override modifiers in class elements
class Foo extends  {
  override method() {}
}
static index signatures ([key: KeyType]: ValueType) in classes
class Foo {
  static [key: string]: Bar;
}
get / set in type declarations
interface Foo {
  set foo(value);
  get foo(): string;
}
Preserve attributes order for element node (#​10958 by @​dcyriller)
{{!-- Input --}}
<MyComponent
  {{! this is a comment for arg 1}}
  @&#8203;arg1="hello"
  {{on "clik" this.modify}}
  @&#8203;arg2="hello"
  {{! this is a comment for arg 3}}
  @&#8203;arg3="hello"
  @&#8203;arg4="hello"
  {{! this is a comment for arg 5}}
  @&#8203;arg5="hello"
  ...arguments
/>
{{!-- Prettier stable --}}
<MyComponent
  @&#8203;arg1="hello"
  @&#8203;arg2="hello"
  @&#8203;arg3="hello"
  @&#8203;arg4="hello"
  @&#8203;arg5="hello"
  ...arguments
  {{on "clik" this.modify}}
  {{! this is a comment for arg 1}}
  {{! this is a comment for arg 3}}
  {{! this is a comment for arg 5}}
/>
{{!-- Prettier main --}}
<MyComponent
  {{! this is a comment for arg 1}}
  @&#8203;arg1="hello"
  {{on "clik" this.modify}}
  @&#8203;arg2="hello"
  {{! this is a comment for arg 3}}
  @&#8203;arg3="hello"
  @&#8203;arg4="hello"
  {{! this is a comment for arg 5}}
  @&#8203;arg5="hello"
  ...arguments
/>
Track cursor position properly when it’s at the end of the range to format (#​10938 by @​j-f1)

Previously, if the cursor was at the end of the range to format, it would simply be placed back at the end of the updated range.
Now, it will be repositioned if Prettier decides to add additional code to the end of the range (such as a semicolon).

// Input (<|> represents the cursor)
const someVariable = myOtherVariable<|>
// range to format:  ^^^^^^^^^^^^^^^

// Prettier stable
const someVariable = myOtherVariable;<|>
// range to format:  ^^^^^^^^^^^^^^^

// Prettier main
const someVariable = myOtherVariable<|>;
// range to format:  ^^^^^^^^^^^^^^^
Break the LHS of type alias that has complex type parameters (#​10901 by @​sosukesuzuki)
// Input
type FieldLayoutWith<
  T extends string,
  S extends unknown = { width: string }
> = {
  type: T;
  code: string;
  size: S;
};

// Prettier stable
type FieldLayoutWith<T extends string, S extends unknown = { width: string }> =
  {
    type: T;
    code: string;
    size: S;
  };

// Prettier main
type FieldLayoutWith<
  T extends string,
  S extends unknown = { width: string }
> = {
  type: T;
  code: string;
  size: S;
};
Break the LHS of assignments that has complex type parameters (#​10916 by @​sosukesuzuki)
// Input
const map: Map<
  Function,
  Map<string | void, { value: UnloadedDescriptor }>
> = new Map();

// Prettier stable
const map: Map<Function, Map<string | void, { value: UnloadedDescriptor }>> =
  new Map();

// Prettier main
const map: Map<
  Function,
  Map<string | void, { value: UnloadedDescriptor }>
> = new Map();
Fix incorrectly wrapped arrow functions with return types (#​10940 by @​thorn0)
// Input
longfunctionWithCall12("bla", foo, (thing: string): complex<type<something>> => {
  code();
});

// Prettier stable
longfunctionWithCall12("bla", foo, (thing: string): complex<
  type<something>
> => {
  code();
});

// Prettier main
longfunctionWithCall12(
  "bla",
  foo,
  (thing: string): complex<type<something>> => {
    code();
  }
);
Avoid breaking call expressions after assignments with complex type arguments (#​10949 by @​sosukesuzuki)
// Input
const foo = call<{
  prop1: string;
  prop2: string;
  prop3: string;
}>();

// Prettier stable
const foo =
  call<{
    prop1: string;
    prop2: string;
    prop3: string;
  }>();

// Prettier main
const foo = call<{
  prop1: string;
  prop2: string;
  prop3: string;
}>();
Fix order of override modifiers (#​10961 by @​sosukesuzuki)
// Input
class Foo extends Bar {
  abstract override foo: string;
}

// Prettier stable
class Foo extends Bar {
  abstract override foo: string;
}

// Prettier main
class Foo extends Bar {
  abstract override foo: string;
}

v2.3.0

Compare Source

diff

🔗 [Release Notes](https://prettier.io/blog


Configuration

📅 Schedule: "after 9:30am every weekday,before 6:30pm every weekday" in timezone Asia/Tokyo.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner June 17, 2021 08:14
@renovate renovate bot requested review from penicillin0 and removed request for a team June 17, 2021 08:14
@renovate renovate bot added the renovate label Jun 17, 2021
@netlify
Copy link

netlify bot commented Jun 17, 2021

✔️ Deploy Preview for ingred-ui ready!

🔨 Explore the source changes: ef5f29c

🔍 Inspect the deploy log: https://app.netlify.com/sites/ingred-ui/deploys/60cc0cf074196a0007fc6bdd

😎 Browse the preview: https://deploy-preview-386--ingred-ui.netlify.app

@renovate
Copy link
Contributor Author

renovate bot commented Jun 17, 2021

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you check the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: testEnv/yarn.lock
error Package "ingred-ui" refers to a non-existing file '"/mnt/renovate/gh/voyagegroup/ingred-ui/dist"'.

@youchann youchann self-assigned this Jun 18, 2021
Comment on lines +25 to +28
// ref: https://github.com/styleguidist/react-docgen-typescript/issues/356#issuecomment-857887751
typescript: {
reactDocgen: "react-docgen",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

型をパースしてくれるやつが2種類あって、

  • react-docgen-typescript
  • react-docgen

前者がデフォだけど、動かないので後者を利用。といった感じ。

@@ -3,6 +3,7 @@ module.exports = {
transform: {
"^.+\\.tsx?$": "ts-jest",
},
testPathIgnorePatterns: ["/node_modules/", "/testEnv/", "/examples/"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testEnvが含まれていることによって出るWarningを消すため、明示的にignoreした。

Comment on lines +47 to +48
const normalBackgroundColor =
getNormalBackgroundColor(theme)[colorForStyle];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettierの変更が多い

@@ -3,13 +3,13 @@
exports[`ActionButton component testing ActionButton 1`] = `
<DocumentFragment>
<button
class="sc-bdvvaa enRipp"
class="sc-bdnxRM JueWW"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

テストの変更も同様に多い

@@ -18,7 +18,7 @@ const Input = React.forwardRef<
<Styled.Input
{...rest}
ref={ref as any}
as={multiline ? "textarea" : "input"}
as={(multiline ? "textarea" : "input") as any}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここ、型の記述をたどれば何かが書いてある。

export interface StyledComponentBase<
    C extends string | React.ComponentType<any>,
    T extends object,
    O extends object = {},
    A extends keyof any = never
> extends ForwardRefExoticBase<StyledComponentProps<C, T, O, A>> {
    // add our own fake call signature to implement the polymorphic 'as' prop
    (props: StyledComponentProps<C, T, O, A> & { as?: never; forwardedAs?: never }): React.ReactElement<
        StyledComponentProps<C, T, O, A>
    >;
    <AsC extends string | React.ComponentType<any> = C, FAsC extends string | React.ComponentType<any> = C>(
        props: StyledComponentPropsWithAs<C, T, O, A, AsC, FAsC>,
    ): React.ReactElement<StyledComponentPropsWithAs<C, T, O, A, AsC, FAsC>>;

    withComponent<WithC extends AnyStyledComponent>(
..........

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add our own fake call signature to implement the polymorphic 'as' prop

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blameしたけど、これ結構前からあるんだよな、わからない

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あきらめる

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このコンポーネントの動作自体は無問題

@youchann youchann requested review from ryokosuge and removed request for penicillin0 June 18, 2021 02:50
{
"matchPackagePatterns": ["^@types/"],
"automerge": true
},
{
"matchPackagePatterns": ["^@testing-library/"],
"automerge": true
},
{
"groupName": "non-major",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

順番を変えてみた。このPRに@types/で引っかかるべき依存の更新があったので

@@ -9,21 +9,22 @@
"after 9:30am every weekday",
"before 6:30pm every weekday"
],
"recreateClosed": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

手動でcloseしてしまったやつがあるので、そういった者たちを復活させる。

@@ -1,29 +1,29 @@
{
"extends": [
"config:base",
":enableVulnerabilityAlertsWithLabel(security)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependabotに移譲したので、もういらないという判断

Copy link
Contributor

@ryokosuge ryokosuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@youchann youchann merged commit 7ffa618 into master Jun 21, 2021
@youchann youchann deleted the renovate/non-major branch June 21, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants