-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update non-major #386
Update non-major #386
Conversation
クラス名が変わっただけ
✔️ Deploy Preview for ingred-ui ready! 🔨 Explore the source changes: ef5f29c 🔍 Inspect the deploy log: https://app.netlify.com/sites/ingred-ui/deploys/60cc0cf074196a0007fc6bdd 😎 Browse the preview: https://deploy-preview-386--ingred-ui.netlify.app |
b3990fb
to
2b1c602
Compare
⚠ Artifact update problemRenovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens:
The artifact failure details are included below: File name: testEnv/yarn.lock
|
// ref: https://github.com/styleguidist/react-docgen-typescript/issues/356#issuecomment-857887751 | ||
typescript: { | ||
reactDocgen: "react-docgen", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
型をパースしてくれるやつが2種類あって、
- react-docgen-typescript
- react-docgen
前者がデフォだけど、動かないので後者を利用。といった感じ。
@@ -3,6 +3,7 @@ module.exports = { | |||
transform: { | |||
"^.+\\.tsx?$": "ts-jest", | |||
}, | |||
testPathIgnorePatterns: ["/node_modules/", "/testEnv/", "/examples/"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testEnv
が含まれていることによって出るWarningを消すため、明示的にignoreした。
const normalBackgroundColor = | ||
getNormalBackgroundColor(theme)[colorForStyle]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettierの変更が多い
@@ -3,13 +3,13 @@ | |||
exports[`ActionButton component testing ActionButton 1`] = ` | |||
<DocumentFragment> | |||
<button | |||
class="sc-bdvvaa enRipp" | |||
class="sc-bdnxRM JueWW" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
テストの変更も同様に多い
@@ -18,7 +18,7 @@ const Input = React.forwardRef< | |||
<Styled.Input | |||
{...rest} | |||
ref={ref as any} | |||
as={multiline ? "textarea" : "input"} | |||
as={(multiline ? "textarea" : "input") as any} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここ、型の記述をたどれば何かが書いてある。
export interface StyledComponentBase<
C extends string | React.ComponentType<any>,
T extends object,
O extends object = {},
A extends keyof any = never
> extends ForwardRefExoticBase<StyledComponentProps<C, T, O, A>> {
// add our own fake call signature to implement the polymorphic 'as' prop
(props: StyledComponentProps<C, T, O, A> & { as?: never; forwardedAs?: never }): React.ReactElement<
StyledComponentProps<C, T, O, A>
>;
<AsC extends string | React.ComponentType<any> = C, FAsC extends string | React.ComponentType<any> = C>(
props: StyledComponentPropsWithAs<C, T, O, A, AsC, FAsC>,
): React.ReactElement<StyledComponentPropsWithAs<C, T, O, A, AsC, FAsC>>;
withComponent<WithC extends AnyStyledComponent>(
..........
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add our own fake call signature to implement the polymorphic 'as' prop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blameしたけど、これ結構前からあるんだよな、わからない
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あきらめる
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
このコンポーネントの動作自体は無問題
{ | ||
"matchPackagePatterns": ["^@types/"], | ||
"automerge": true | ||
}, | ||
{ | ||
"matchPackagePatterns": ["^@testing-library/"], | ||
"automerge": true | ||
}, | ||
{ | ||
"groupName": "non-major", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
順番を変えてみた。このPRに@types/
で引っかかるべき依存の更新があったので
@@ -9,21 +9,22 @@ | |||
"after 9:30am every weekday", | |||
"before 6:30pm every weekday" | |||
], | |||
"recreateClosed": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
手動でcloseしてしまったやつがあるので、そういった者たちを復活させる。
@@ -1,29 +1,29 @@ | |||
{ | |||
"extends": [ | |||
"config:base", | |||
":enableVulnerabilityAlertsWithLabel(security)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dependabotに移譲したので、もういらないという判断
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR contains the following updates:
5.12.0
->5.14.1
11.2.6
->11.2.7
12.19.9
->12.20.15
17.0.5
->17.0.11
17.0.4
->17.0.11
17.0.5
->17.0.7
17.0.3
->17.0.7
5.1.5
->5.1.10
5.1.9
->5.1.10
4.22.0
->4.27.0
4.22.0
->4.27.0
7.25.0
->7.28.0
2.22.1
->2.23.4
1.12.0
->1.13.0
7.23.2
->7.24.0
2.2.1
->2.3.1
6.13.1
->6.15.8
2.45.2
->2.52.1
5.2.1
->5.3.0
5.2.3
->5.3.0
26.5.5
->26.5.6
4.1.3
->4.3.4
4.2.4
->4.3.4
Release Notes
testing-library/jest-dom
v5.14.1
Compare Source
Bug Fixes
v5.14.0
Compare Source
Features
v5.13.0
Compare Source
Features
toHaveErrorMessage
matcher (#370) (217fdcc)testing-library/react-testing-library
v11.2.7
Compare Source
Bug Fixes
process
not being defined (#911) (8a1c8e9)typescript-eslint/typescript-eslint
v4.27.0
Compare Source
Bug Fixes
Features
LogicalExpression
'soperator
type (#3497) (9e343fd)PunctuatorToken
'svalue
type (#3496) (fdb1d81)4.26.1 (2021-06-07)
Bug Fixes
v4.26.1
Compare Source
Bug Fixes
v4.26.0
Compare Source
Bug Fixes
Features
v4.25.0
Compare Source
Bug Fixes
isAwaitKeyword
predicate in ast-utils (#3290) (c15da67)Features
v4.24.0
Compare Source
Bug Fixes
Features
noPropertyAccessFromIndexSignature
(#3361) (37ec2c2)v4.23.0
Compare Source
Bug Fixes
Features
getCwd()
inRuleContext
type (#3308) (2b75c11)4.22.1 (2021-05-04)
Note: Version bump only for package @typescript-eslint/typescript-eslint
v4.22.1
Compare Source
Note: Version bump only for package @typescript-eslint/typescript-eslint
eslint/eslint
v7.28.0
Compare Source
1237705
Upgrade: @eslint/eslintrc to 0.4.2 (#14672) (Milos Djermanovic)123fb86
Docs: Add Feedback Needed triage description (#14670) (Nicholas C. Zakas)c545163
Update: support multiline /eslint-env/ directives (fixes #14652) (#14660) (薛定谔的猫)8d1e75a
Upgrade: glob-parent version in package.json (#14658) (Hamza Najeeb)1f048cb
Fix: no-implicit-coercion false positive withString()
(fixes #14623) (#14641) (Milos Djermanovic)d709abf
Chore: fix comment location in no-unused-vars (#14648) (Milos Djermanovic)e44ce0a
Fix: no-duplicate-imports allow unmergeable (fixes #12758, fixes #12760) (#14238) (Soufiane Boutahlil)bb66a3d
New: addgetPhysicalFilename()
method to rule context (fixes #11989) (#14616) (Nitin Kumar)2e43dac
Docs: fixno-sequences
example (#14643) (Nitin Kumar)958ff4e
Docs: add note for arrow functions in no-seq rule (#14578) (Nitin Kumar)e4f111b
Fix: arrow-body-style crash with object pattern (fixes #14633) (#14635) (Milos Djermanovic)ec28b5a
Chore: upgrade eslint-plugin-eslint-plugin (#14590) (薛定谔的猫)85a2725
Docs: Update README team and sponsors (ESLint Jenkins)v7.27.0
Compare Source
2c0868c
Chore: merge all html formatter files intohtml.js
(#14612) (Milos Djermanovic)9e9b5e0
Update: no-unused-vars false negative with comma operator (fixes #14325) (#14354) (Nitin Kumar)afe9569
Chore: use includes instead of indexOf (#14607) (Mikhail Bodrov)c0f418e
Chore: Remove lodash (#14287) (Stephen Wade)52655dd
Update: no-restricted-imports custom message for patterns (fixes #11843) (#14580) (Alex Holden)967b1c4
Chore: Fix typo in large.js (#14589) (Ikko Ashimine)2466a05
Sponsors: Sync README with website (ESLint Jenkins)fe29f18
Sponsors: Sync README with website (ESLint Jenkins)086c1d6
Chore: add more test cases forno-sequences
(#14579) (Nitin Kumar)6a2ced8
Docs: Update README team and sponsors (ESLint Jenkins)v7.26.0
Compare Source
aaf65e6
Upgrade: eslintrc for ModuleResolver fix (#14577) (Brandon Mills)ae6dbd1
Fix: track variables, not names in require-atomic-updates (fixes #14208) (#14282) (Patrick Ahmetovic)6a86e50
Chore: remove loose-parser tests (fixes #14315) (#14569) (Milos Djermanovic)ee3a3ea
Fix: create.eslintrc.cjs
formodule
type (#14304) (Nitin Kumar)6791dec
Docs: fix example for require-atomic-updates (#14562) (Milos Djermanovic)388eb7e
Sponsors: Sync README with website (ESLint Jenkins)f071d1e
Update: Add automated suggestion toradix
rule for parsing decimals (#14291) (Bryan Mishkin)0b6a3f3
New: Include XO style guide ineslint --init
(#14193) (Federico Brigante)benmosher/eslint-plugin-import
v2.23.4
Compare Source
Fixed
no-import-module-exports
]: Don't crash if packages have no entrypoint ([#2099], thanks [@eps1lon])no-extraneous-dependencies
]: fix package name algorithm ([#2097], thanks [@paztis])v2.23.3
Compare Source
Fixed
no-restricted-paths
]: fix false positive matches ([#2090], thanks [@malykhinvi])no-cycle
]: ignore imports where imported file only imports types of importing file ([#2083], thanks [@cherryblossom000])no-cycle
]: fix false negative when file imports a type after importing a value in Flow ([#2083], thanks [@cherryblossom000])order
]: restore default behavior unlesstype
is in groups ([#2087], thanks [@grit96])Changed
no-relative-packages
to list of to the list of rules ([#2075], thanks [@arvigeus])v2.23.2
Compare Source
Changed
safe-publish-latest
; useprepublishOnly
script for npm 7+v2.23.1
Compare Source
Fixed
newline-after-import
]: fix crash withexport {}
syntax ([#2063], [#2056], thanks [@ljharb])ExportMap
: do not crash when tsconfig lacks.compilerOptions
([#2067], thanks [@ljharb])order
]: fix alphabetical sorting ([#2071], thanks [@grit96])v2.23.0
Compare Source
Added
no-commonjs
]: Also detect require calls with expressionless template literals:require(`x`)
([#1958], thanks [@FloEdelmann])no-internal-modules
]: Addforbid
option ([#1846], thanks [@guillaumewuip])no-relative-packages
] ([#1860], [#966], thanks [@tapayne88] [@panrafal])no-import-module-exports
] rule: report import declarations with CommonJS exports ([#804], thanks [@kentcdodds] and [@ttmarek])no-unused-modules
]: Support destructuring assignment forexport
. ([#1997], thanks [@s-h-a-d-o-w])order
]: support type imports ([#2021], thanks [@grit96])order
]: AddwarnOnUnassignedImports
option to enable warnings for out of order unassigned imports ([#1990], thanks [@hayes])Fixed
export
]/TypeScript: properly detect export specifiers as children of a TS module block ([#1889], thanks [@andreubotella])order
]: ignore non-module-level requires ([#1940], thanks [@golopot])no-webpack-loader-syntax
]/TypeScript: avoid crash on missing name ([#1947], thanks [@leonardodino])no-extraneous-dependencies
]: Add package.json cache ([#1948], thanks [@fa93hws])prefer-default-export
]: handle empty array destructuring ([#1965], thanks [@ljharb])no-unused-modules
]: make type imports mark a module as used (fixes #1924) ([#1974], thanks [@cherryblossom000])no-cycle
]: fix perf regression ([#1944], thanks [@Blasz])first
]: fix handling ofimport = require
([#1963], thanks [@MatthiasKunnen])no-cycle
]/[extensions
]: fix isExternalModule usage ([#1696], thanks [@paztis])extensions
]/[no-cycle
]/[no-extraneous-dependencies
]: Correct module real path resolution ([#1696], thanks [@paztis])no-named-default
]: ignore Flow import type and typeof ([#1983], thanks [@christianvuerings])no-extraneous-dependencies
]: Exclude flowtypeof
imports ([#1534], thanks [@devongovett])newline-after-import
]: respect decorator annotations ([#1985], thanks [@lilling])no-restricted-paths
]: enhance performance for zones withexcept
paths ([#2022], thanks [@malykhinvi])no-unresolved
]: check import() ([#2026], thanks [@aladdin-add])Changed
no-named-as-default
]: add semicolon ([#1897], thanks [@bicstone])no-extraneous-dependencies
: correct peerDependencies option default totrue
([#1993], thanks [@dwardu])order
: Document options required to match ordering example ([#1992], thanks [@silviogutierrez])no-unresolved
: add tests forimport()
([#2012], thanks [@davidbonnet])mdx-js/eslint-mdx
v1.13.0
Compare Source
Bug Fixes
Features
yannickcr/eslint-plugin-react
v7.24.0
Compare Source
Added
no-unused-prop-types
]: add ignore option (#2972 @grit96)Fixed
jsx-handler-names
]: properly substitute value into message (#2975 @G-Rath)jsx-uses-vars
]: ignore namespaces (#2985 @remcohaszing)jsx-no-undef
]: ignore namespaces (#2986 @remcohaszing)jsx-child-element-spacing
]: Don't flag whitespace around<br/>
tags (#2989 @pascalpp)Changed
jsx-newline
]: Fix minor spelling error on rule name (#2974 @DennisSkoko)void-dom-elements-no-children
]: improve performancejsx-child-element-spacing
]: fixes sentence which ends abruptly (#2990 @pascalpp)prettier/prettier
v2.3.1
Compare Source
diff
Support TypeScript 4.3 (#10945 by @sosukesuzuki)
override
modifiers in class elementsstatic index signatures (
[key: KeyType]: ValueType
) in classesget
/set
in type declarationsPreserve attributes order for element node (#10958 by @dcyriller)
Track cursor position properly when it’s at the end of the range to format (#10938 by @j-f1)
Previously, if the cursor was at the end of the range to format, it would simply be placed back at the end of the updated range.
Now, it will be repositioned if Prettier decides to add additional code to the end of the range (such as a semicolon).
Break the LHS of type alias that has complex type parameters (#10901 by @sosukesuzuki)
Break the LHS of assignments that has complex type parameters (#10916 by @sosukesuzuki)
Fix incorrectly wrapped arrow functions with return types (#10940 by @thorn0)
Avoid breaking call expressions after assignments with complex type arguments (#10949 by @sosukesuzuki)
Fix order of
override
modifiers (#10961 by @sosukesuzuki)v2.3.0
Compare Source
diff
🔗 [Release Notes](https://prettier.io/blog
Configuration
📅 Schedule: "after 9:30am every weekday,before 6:30pm every weekday" in timezone Asia/Tokyo.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by WhiteSource Renovate. View repository job log here.