-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<DataTable />でデフォルトチェックを有効にする #399
Conversation
✔️ Deploy Preview for ingred-ui ready! 🔨 Explore the source changes: c97653d 🔍 Inspect the deploy log: https://app.netlify.com/sites/ingred-ui/deploys/60d599c78ed0bb00080cde93 😎 Browse the preview: https://deploy-preview-399--ingred-ui.netlify.app/iframe |
{(args) => ( | ||
<DataTable | ||
data={data.slice(0, 4)} | ||
columns={[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一瞬undefined
が入るようになっていて、そのせいでエラーが起きるようになっていた........
mdxやめたい.......:bow:
* Not rerender when this prop is updated because it is used for initial value of state. | ||
* **Please use with `onSelectRowChange={true}`.** | ||
*/ | ||
defaultSelectedRow?: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storybook上でも確認できる
{...(!disableCheckWhenClickRow && { | ||
onClick: handleSelectCheckbox(item.id), | ||
})} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undefined書きたくないときの方法
@ryokosuge |
@deatiger 結局自分で書いてしまいましたmm
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ありがとうございます!素敵実装です👏 |
.tsx
に書き換える