rollup周りのエラー対応 #426
Merged
rollup周りのエラー対応 #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for ingred-ui ready! 🔨 Explore the source changes: fda983f 🔍 Inspect the deploy log: https://app.netlify.com/sites/ingred-ui/deploys/611481626af05c0007af4206 😎 Browse the preview: https://deploy-preview-426--ingred-ui.netlify.app/ |
youchann
commented
Aug 12, 2021
Comment on lines
+42
to
+45
| "@rollup/plugin-commonjs": "20.0.0", | ||
| "@rollup/plugin-node-resolve": "13.0.4", | ||
| "@rollup/plugin-typescript": "8.2.5", | ||
| "@rollup/plugin-url": "6.1.0", |
There was a problem hiding this comment.
なるべく公式プラグインを利用するようにした
youchann
commented
Aug 12, 2021
| ], | ||
| }, | ||
| }), | ||
| typescript({ tsconfig: "./tsconfig.json" }), |
There was a problem hiding this comment.
明示的に書かないとtsconfig.jsonをみてくれなさそうだった
youchann
commented
Aug 12, 2021
Comment on lines
+3
to
+5
| "outDir": "dist", | ||
| "declaration": true, | ||
| "declarationDir": ".", |
There was a problem hiding this comment.
今まではrollup-plugin-typescript2側で書かれていたtsconfig.jsonを用いられていたけど、今後は当ファイルを用いてコンパイルされる。
なので調整した。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
最新のバージョンは利用できない状態になっている。
原因は
rollupがうまく動いていないため。やったこと
rollup及びそのプラグイン周りのアップデートrollup.config.jsの調整検証方法
$yarn buildでバンドルするtestEnv/でページが表示できるか確認