react-transition-group の warning 対応 #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for ingred-ui ready! 🔨 Explore the source changes: 21ef0ec 🔍 Inspect the deploy log: https://app.netlify.com/sites/ingred-ui/deploys/61ee52af8b626200089d27a4 😎 Browse the preview: https://deploy-preview-684--ingred-ui.netlify.app |
takurinton
commented
Jan 24, 2022
| appear={true} | ||
| mountOnEnter={true} | ||
| timeout={timeout} | ||
| classNames={Styled.transitionClass} | ||
| {...rest} | ||
| > | ||
| {children} | ||
| <div ref={nodeRef}>{children}</div> |
There was a problem hiding this comment.
CSSTransition の中に div タグ作ってそこにも ref を渡さないとアニメーションのためのイベントがうまく伝達されない。
reactjs/react-transition-group#668 (comment)
<CSSTransition nodeRef={nodeRef}>
<div ref={nodeRef}>
{children}
</div>
</CSSTransition>
|
|
youchann
reviewed
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toast で内部的に使用している react-transition-group が、findDOMNodeに直接変更を加えている行為が非推奨だったため、nodeRef という props を追加して対処した。
reactjs/react-transition-group#429 (comment)
それに合わせた対応。