ButtonGroupの左右paddingを16pxにする #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinokoruumu
suggested changes
Jun 12, 2020
| > = { | ||
| small: { | ||
| minWidth: "63px", | ||
| height: "32px", | ||
| padding: 1, |
There was a problem hiding this comment.
左右にしか当てないならhorizontalPaddingとかの方がいいな(もし上下も定義するなら名前かぶるので。)
それとpaddingはbuttonのsizeというよりstyleかな...
あと、倍率を定義するならそういう命名の方が良さそう
https://github.com/voyagegroup/ingred-ui/blob/master/src/components/Button/Button.tsx#L115
これ参考にしてもらえると
There was a problem hiding this comment.
了解です！
horizontalPaddingを定義して追加することにします
kinokoruumu
approved these changes
Jun 12, 2020
| @@ -28,6 +29,10 @@ const ButtonGroup: React.FunctionComponent<Props> = ({ | |||
| disabled = false, | |||
| children, | |||
| }) => { | |||
| const theme = useTheme(); | |||
| const horizontalPadding = | |||
| size === "small" ? `${theme.spacing * 1}px` : `${theme.spacing * 2}px`; | |||
There was a problem hiding this comment.
Suggested change
| size === "small" ? `${theme.spacing * 1}px` : `${theme.spacing * 2}px`; | |
| size === "small" ? `${theme.spacing}px` : `${theme.spacing * 2}px`; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #74
size: mediumのみ