Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<NavigationRails />, <ContextMenu />の微調整 #79

Merged
merged 9 commits into from
Jun 16, 2020

Conversation

youchann
Copy link
Contributor

@youchann youchann commented Jun 15, 2020

やったこと

  • NavigationRails

    • アイコン横のテキストの縦方向を中央に寄せる(↓ずれてる図)
      image

    • <ExpantionMenuItem />をhover時に色を変える

      • font-weight: bold;ではなく、background-color: background-color: ${({ theme }) => theme.palette.gray.light};にした。(画像の下の部分のコンポーネント)
        image
  • ContextMenu

    • width, heightを固定する
      • 長方形になってしまっている↓ので、34x34pxの正方形にした。
        image

@youchann youchann self-assigned this Jun 15, 2020
@youchann youchann requested a review from maktak1995 June 16, 2020 01:26
@youchann
Copy link
Contributor Author

Copy link
Contributor

@maktak1995 maktak1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@youchann youchann merged commit c957560 into master Jun 16, 2020
@youchann youchann deleted the tweak-navigation-rails branch June 16, 2020 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants