Buttonにcomponent propsを追加 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youchann
commented
Jun 17, 2020
Comment on lines
+23
to
+32
| const Link: React.FunctionComponent<{ href: string; className: string }> = ({ | ||
| href, | ||
| className, | ||
| children, | ||
| }) => ( | ||
| <a href={href} className={className} onClick={action("clicked")}> | ||
| {children} | ||
| </a> | ||
| ); | ||
|
|
There was a problem hiding this comment.
使う側として気をつけないといけないのが、renderされる要素のtop-levelにclassNamepropを付与しないとスタイリングされないことです。
https://styled-components.com/docs/basics#styling-any-component
これに関してはButtonコンポーネントが干渉できない部分なので、使う側が気をつけないとなぁという感じですね。
kinokoruumu
approved these changes
Jun 18, 2020
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #69