Add CRD Validation (#962)

ref: https://kubernetes.io/docs/tasks/access-kubernetes-api/extend-api-custom-resource-definitions/#validation

apis/voyager/v1beta1/certificate.go

@@ -6,9 +6,9 @@ import (
 )
 
 const (
-	ResourceKindCertificate = "Certificate"
-	ResourceNameCertificate = "certificate"
-	ResourceTypeCertificate = "certificates"
+	ResourceKindCertificate     = "Certificate"
+	ResourceSingularCertificate = "certificate"
+	ResourcePluralCertificate   = "certificates"
 )
 
 // +genclient

apis/voyager/v1beta1/crd.go

@@ -1,49 +1,44 @@
 package v1beta1
 
 import (
-	"github.com/appscode/voyager/apis/voyager"
+	crdutils "github.com/appscode/kutil/apiextensions/v1beta1"
 	apiextensions "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
-const VoyagerFinalizer = "voyager.appscode.com"
-
 func (r Ingress) CustomResourceDefinition() *apiextensions.CustomResourceDefinition {
-	return &apiextensions.CustomResourceDefinition{
-		ObjectMeta: metav1.ObjectMeta{
-			Name:   ResourceTypeIngress + "." + SchemeGroupVersion.Group,
-			Labels: map[string]string{"app": "voyager"},
-		},
-		Spec: apiextensions.CustomResourceDefinitionSpec{
-			Group:   voyager.GroupName,
-			Version: SchemeGroupVersion.Version,
-			Scope:   apiextensions.NamespaceScoped,
-			Names: apiextensions.CustomResourceDefinitionNames{
-				Singular:   ResourceNameIngress,
-				Plural:     ResourceTypeIngress,
-				Kind:       ResourceKindIngress,
-				ShortNames: []string{"ing"},
-			},
+	return crdutils.NewCustomResourceDefinition(crdutils.Config{
+		Group:         SchemeGroupVersion.Group,
+		Version:       SchemeGroupVersion.Version,
+		Plural:        ResourcePluralIngress,
+		Singular:      ResourceSingularIngress,
+		Kind:          ResourceKindIngress,
+		ListKind:      ResourceKindIngress + "List",
+		ShortNames:    []string{"ing"},
+		ResourceScope: string(apiextensions.NamespaceScoped),
+		Labels: crdutils.Labels{
+			LabelsMap: map[string]string{"app": "voyager"},
 		},
-	}
+		SpecDefinitionName:    "github.com/appscode/voyager/apis/voyager/v1beta1.Ingress",
+		EnableValidation:      true,
+		GetOpenAPIDefinitions: GetOpenAPIDefinitions,
+	})
 }
 
 func (c Certificate) CustomResourceDefinition() *apiextensions.CustomResourceDefinition {
-	return &apiextensions.CustomResourceDefinition{
-		ObjectMeta: metav1.ObjectMeta{
-			Name:   ResourceTypeCertificate + "." + SchemeGroupVersion.Group,
-			Labels: map[string]string{"app": "voyager"},
-		},
-		Spec: apiextensions.CustomResourceDefinitionSpec{
-			Group:   voyager.GroupName,
-			Version: SchemeGroupVersion.Version,
-			Scope:   apiextensions.NamespaceScoped,
-			Names: apiextensions.CustomResourceDefinitionNames{
-				Singular:   ResourceNameCertificate,
-				Plural:     ResourceTypeCertificate,
-				Kind:       ResourceKindCertificate,
-				ShortNames: []string{"cert"},
-			},
+	return crdutils.NewCustomResourceDefinition(crdutils.Config{
+		Group:         SchemeGroupVersion.Group,
+		Version:       SchemeGroupVersion.Version,
+		Plural:        ResourcePluralCertificate,
+		Singular:      ResourceSingularCertificate,
+		Kind:          ResourceKindCertificate,
+		ListKind:      ResourceKindCertificate + "List",
+		ShortNames:    []string{"cert"},
+		ResourceScope: string(apiextensions.NamespaceScoped),
+		Labels: crdutils.Labels{
+			LabelsMap: map[string]string{"app": "voyager"},
 		},
-	}
+		SpecDefinitionName:    "github.com/appscode/voyager/apis/voyager/v1beta1.Certificate",
+		EnableValidation:      true,
+		GetOpenAPIDefinitions: GetOpenAPIDefinitions,
+	})
 }

apis/voyager/v1beta1/diff.go

@@ -8,6 +8,7 @@ import (
 	"time"
 
 	core_util "github.com/appscode/kutil/core/v1"
+	"github.com/appscode/voyager/apis/voyager"
 	"github.com/google/go-cmp/cmp"
 	"github.com/pkg/errors"
 	"k8s.io/apimachinery/pkg/api/resource"
@@ -39,7 +40,7 @@ func (r Ingress) HasChanged(o Ingress) (bool, error) {
 		return false, errors.New("not the same Ingress")
 	}
 
-	if o.DeletionTimestamp != nil && core_util.HasFinalizer(o.ObjectMeta, VoyagerFinalizer) {
+	if o.DeletionTimestamp != nil && core_util.HasFinalizer(o.ObjectMeta, voyager.GroupName) {
 		return true, nil
 	}
 

apis/voyager/v1beta1/ingress.go

@@ -7,9 +7,9 @@ import (
 )
 
 const (
-	ResourceKindIngress = "Ingress"
-	ResourceNameIngress = "ingress"
-	ResourceTypeIngress = "ingresses"
+	ResourceKindIngress     = "Ingress"
+	ResourceSingularIngress = "ingress"
+	ResourcePluralIngress   = "ingresses"
 )
 
 // +genclient

glide.yaml

@@ -47,7 +47,7 @@ import:
 - package: github.com/spf13/cobra
   version: master
 - package: github.com/spf13/pflag
-  version: v1.0.0
+  version: master
 - package: github.com/tredoe/osutil
 - package: github.com/xenolf/lego
   repo: https://github.com/appscode/lego.git

hack/gencrd/main.go

@@ -0,0 +1,29 @@
+package main
+
+import (
+	"os"
+
+	"github.com/appscode/go/log"
+	"github.com/appscode/go/runtime"
+	crdutils "github.com/appscode/kutil/apiextensions/v1beta1"
+	api "github.com/appscode/voyager/apis/voyager/v1beta1"
+	crd_api "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1"
+)
+
+func main() {
+	filename := runtime.GOPath() + "/src/github.com/appscode/voyager/apis/voyager/v1beta1/crds.yaml"
+
+	f, err := os.OpenFile(filename, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)
+	if err != nil {
+		log.Fatal(err)
+	}
+	defer f.Close()
+
+	crds := []*crd_api.CustomResourceDefinition{
+		api.Ingress{}.CustomResourceDefinition(),
+		api.Certificate{}.CustomResourceDefinition(),
+	}
+	for _, crd := range crds {
+		crdutils.MarshallCrd(f, crd, "yaml")
+	}
+}