Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add out of bound check for KHR header with small images #115

Merged
merged 4 commits into from
Nov 29, 2021

Conversation

tragamota
Copy link
Contributor

@tragamota tragamota commented Nov 29, 2021

Fix for small images

I included an example image that creates a out of bounds exception

Couldn't upload webp files to github so please change the extension to .webp instead of .png

test (1)

@vpenades
Copy link
Owner

@tragamota could you undo the style changes and leave only the changes that are relevant to the PR? that way it will be easier for me to do a review.

@tragamota
Copy link
Contributor Author

@vpenades Sorry for the style changes. Forgot to disable my autoformater.

@vpenades vpenades merged commit c7d222e into vpenades:master Nov 29, 2021
@vpenades
Copy link
Owner

Merged.

On a side note... there's much to do with KHR image validation, there's still not many libraries to look for code examples... so we'll have to live with that for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants