Optimized file generation in WavefrontWriter. #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that it's more robust. Set up platforms for x86 and x64.
…ass to avoid OutOfMemory exceptions in 32-bit mode, which fixes some of the existing tests.
…ow many objects are created and stored in memory at once.
…irectly to the output FileStream rather than first to a MemoryStream and then copying.
…thod so that it's more robust." This reverts commit 4d6b732.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the WavefrontWriter from generating bytes for each file upfront and then saving them to generating bytes lazily via delegates.
Specifically, the old process involved writing to a StringBuilder, saving that to a MemoryStream, and then saving those bytes through File.WriteAllBytes(); now, the new process just writes directly to the FileStream via the Stream interface.
This results in less memory being allocated in total, and allocations being freed up sooner so that they can be reclaimed by the garbage collector.