Add build number and SHA7 to the file properties #245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the build number as well as the sha7 hash value to the file properties and made it analogue to how it is done in Visual Pinball:
Git Workflow updates git_version.h with both values and has version.h include this file and model different types of version strings.
I would have put the git_version.h and version.h in the root folder so that it can be used globally, but I do not know how you want it?
VPinMame automatically returned the build number in the COM version method, but it got it wrong:
The version string went from 03060000 to 0306000870 (one character more).
So I hardcoded 2 zeros instead keeping 03060000 for now. I will address this issue separately.
One more thing to think about, if you now throw in a new VPinMAME.dll and start the Setup routine, it says that you have the file which you are about to install already installed... It cannot find out the right version since it was already replaced.
This might need to be rephrased?