Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build number and SHA7 to the file properties #245

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

JockeJarre
Copy link
Contributor

I added the build number as well as the sha7 hash value to the file properties and made it analogue to how it is done in Visual Pinball:

Git Workflow updates git_version.h with both values and has version.h include this file and model different types of version strings.
I would have put the git_version.h and version.h in the root folder so that it can be used globally, but I do not know how you want it?

image

VPinMame automatically returned the build number in the COM version method, but it got it wrong:

The version string went from 03060000 to 0306000870 (one character more).
So I hardcoded 2 zeros instead keeping 03060000 for now. I will address this issue separately.

One more thing to think about, if you now throw in a new VPinMAME.dll and start the Setup routine, it says that you have the file which you are about to install already installed... It cannot find out the right version since it was already replaced.

image

This might need to be rephrased?

@toxieainc
Copy link
Member

Thanks, i guess this is all good, but as you asked: Please put the version files into root, then we can use it everywhere more easily, thanks!

Copy link
Contributor Author

@JockeJarre JockeJarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @toxieainc , now the files are moved to the root.

@JockeJarre JockeJarre marked this pull request as ready for review March 11, 2024 06:50
@toxieainc toxieainc merged commit 048ac0b into vpinball:master Mar 11, 2024
@toxieainc
Copy link
Member

Thanks!

@rockfordroeNG
Copy link

rockfordroeNG commented Mar 12, 2024

This is causing me some compilation errors when building with the outputs of "create_vc2022_from_vc2012.bat".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants