Increase coverage for is_separable

[purva-thakre]

Description

Fixes #293

Changes

Requires tests for the following lines:

• 74-79
• 109-123
• 131-179

Checklist

Before marking your PR ready for review, make sure you checked the following locally. If this is your first PR, you might be notified of some workflow failures after a maintainer has approved the workflow jobs to be run on your PR.

Additional information is available in the documentation.

• Use ruff and pylint for errors related to code style and formatting.
• Verify all previous and newly added unit tests pass in pytest.
• Check the documentation build does not lead to any failures. Sphinx build can be checked locally for any failures related to your PR
• Use linkcheck to check for broken links in the documentation
• Use doctest to verify the examples in the function docstrings work as expected.

[purva-thakre]

Interestingly the following line shows up as uncovered in the coverage report even though there is a test covering the same lines in the unit tests.

toqito/toqito/state_props/is_separable.py

Lines 78 to 85 in b58f066

	if isinstance(dim, int):
	dim = np.array([dim, state_len / dim]) # pylint: disable=redefined-variable-type
	if np.abs(dim[1] - np.round(dim[1])) >= 2 * state_len * eps:
	raise ValueError("The parameter `dim` must evenly divide the length of the state.")
	dim[1] = np.round(dim[1])
	# nD, xD, pD
	min_dim = int(min(dim))

toqito/toqito/state_props/tests/test_is_separable.py

Lines 23 to 28 in b58f066

	def test_invalid_dim_parameter():
	"""The dimension of the state must evenly divide the length of the state."""
	with np.testing.assert_raises(ValueError):
	dim = 3
	rho = isotropic(dim, 1 / (dim + 1))
	is_separable(rho, dim + 1)

Decided to remove these lines based on a comment in another PR: #335 (comment)

[purva-thakre]

Another interesting thing is the changes in 57b25fc catches more lines as uncovered by unit tests.

Before

After

https://app.codecov.io/gh/vprusso/toqito/pull/509/blob/toqito/state_props/is_separable.py#L185

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.1%. Comparing base (d1049fe) to head (5523138).

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #509     +/-   ##
========================================
- Coverage    98.1%   98.1%   -0.1%     
========================================
  Files         162     162             
  Lines        3112    3109      -3     
  Branches      760     759      -1     
========================================
- Hits         3054    3051      -3     
  Misses         37      37             
  Partials       21      21             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[purva-thakre]

I don't know why the following lines are showing up as uncovered in the pytes coverage.

toqito/toqito/state_props/is_separable.py

Lines 74 to 79 in a1fe746

	if isinstance(dim, int):
	dim = np.array([dim, state_len / dim]) # pylint: disable=redefined-variable-type
	dim[1] = np.round(dim[1])
	# nD, xD, pD
	min_dim = int(min(dim))

The changes in a1fe746 should have covered these. Maybe, this is due to an error in Codecov? Can't see the full coverage report due to some error.

https://app.codecov.io/gh/vprusso/toqito/pull/509?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=Vincent+Russo

Edit: does not appear to be a Codecov issue. I can see the report now but the linked lines are still uncovered.

[purva-thakre]

Temporarily closing this as the branch is out of date.