Skip to content

Commit

Permalink
Change axios to be a peer dependency (#1179)
Browse files Browse the repository at this point in the history
The usage of axios in this repository is very basic, but its versioning
is defined very tightly. This causes problems, because the interface
IOptions uses AxiosInstance as its property, preventing the clients of
this library from updating their axios version beyond the limits set in
this library. Typescript compiler gives type error when giving higher
version AxiosInstance for IOptions.

By setting axios as a peer dependency, we would allow the clients of
this library to install other versions of axios if they so choose.
  • Loading branch information
ssiltanen committed Jan 14, 2022
1 parent 66ba6c6 commit c54e125
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
6 changes: 5 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
},
"author": "Vinay Pulim <v@pulim.com>",
"dependencies": {
"axios": "^0.21.1",
"axios-ntlm": "^1.2.0",
"debug": "^4.3.2",
"formidable": "^1.2.2",
Expand All @@ -19,6 +18,9 @@
"whatwg-mimetype": "3.0.0",
"xml-crypto": "^2.1.3"
},
"peerDependencies": {
"axios": "^0.21.1"
},
"repository": {
"type": "git",
"url": "https://github.com/vpulim/node-soap.git"
Expand Down

0 comments on commit c54e125

Please sign in to comment.